Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect data on SDK Usage #725

Closed
10 of 11 tasks
bartekn opened this issue Oct 24, 2018 · 8 comments
Closed
10 of 11 tasks

Collect data on SDK Usage #725

bartekn opened this issue Oct 24, 2018 · 8 comments

Comments

@bartekn
Copy link
Contributor

bartekn commented Oct 24, 2018

Collect data using HTTP header and save the value in Started request and Finished request log entries. It will be much easier to aggregate if two headers are sent: client name (X-Client-Name) and version (X-Client-Version). Also, it looks like some EventStream implementations (especially implementation found in browsers) don't allow to send custom headers so we should allow sending them via GET parameter. Horizon should check if header is present and if not should check GET params.

SDF:

Community SDKs:

  • Python
  • Scala
  • C#
  • C++
  • Ruby
  • iOS and macOS SDK
@ire-and-curses
Copy link
Member

Python SDK supports this: StellarCN/py-stellar-base@d3052c8

@Synesso
Copy link
Contributor

Synesso commented Feb 28, 2019

This will be present in the next release of Scala SDK.

@ire-and-curses
Copy link
Member

I audited the SDKs and I think they all support this now 🎉

@bartekn from the original description, what docs were you thinking are needed? That's all that's left to close this.

@bartekn
Copy link
Contributor Author

bartekn commented May 22, 2019

@ire-and-curses I was thinking about a simple doc somewhere here explaining what headers should be sent to activate tracking.

@tomquisel
Copy link
Contributor

@theaeolianmachine just a heads up, this should be quick to knock out.

@theaeolianmachine theaeolianmachine removed their assignment Aug 12, 2019
@tomquisel
Copy link
Contributor

@rice2000 can you put it on your list to document these headers as Bartek mentions?

@rice2000
Copy link
Contributor

rice2000 commented Sep 3, 2019

@rice2000 can you put it on your list to document these headers as Bartek mentions?

I added it to the list of new docs to write. Thanks for pointing this out!

@bartekn
Copy link
Contributor Author

bartekn commented May 12, 2020

Looks like it can be closed.

@bartekn bartekn closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants