Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify client SDK + version in request headers #47

Closed
ire-and-curses opened this issue Feb 28, 2019 · 1 comment
Closed

Identify client SDK + version in request headers #47

ire-and-curses opened this issue Feb 28, 2019 · 1 comment

Comments

@ire-and-curses
Copy link

As described in stellar/go#725, it would be really helpful if this SDK sent two simple headers with each request, identifying the SDK and version:

two headers are sent: client name (X-Client-Name) and version (X-Client-Version)

This will help maintainers of public Horizon instances understand where their traffic is coming from, and allow them to assess the impact of upgrading their Horizon version (for example they might delay upgrading to a version with breaking changes not handled by a client SDK with significant traffic to the server).
@ndizazzo ndizazzo mentioned this issue Mar 27, 2019
Merged
@ndizazzo
Copy link
Contributor

ndizazzo commented Mar 27, 2019 •
edited
Loading

Posted an implementation for this in PR #50 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ndizazzo @ire-and-curses @christian-rogobete