Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Identify client SDK + version in request headers #59

Closed
ire-and-curses opened this issue Feb 28, 2019 · 2 comments
Closed

Identify client SDK + version in request headers #59

ire-and-curses opened this issue Feb 28, 2019 · 2 comments
Assignees
@Synesso

Comments

@ire-and-curses
Copy link

As described in stellar/go#725, it would be really helpful if this SDK sent two simple headers with each request, identifying the SDK and version:

two headers are sent: client name (X-Client-Name) and version (X-Client-Version)

This will help maintainers of public Horizon instances understand where their traffic is coming from, and allow them to assess the impact of upgrading their Horizon version (for example they might delay upgrading to a version with breaking changes not handled by a client SDK with significant traffic to the server).
@Synesso
Copy link
Owner

Synesso commented Feb 28, 2019

Thank you @ire-and-curses.

@Synesso Synesso self-assigned this Feb 28, 2019
Synesso added a commit that referenced this issue Feb 28, 2019
@Synesso
[#59] WIP: adding X-Client headers.
ea0b73b 
Need to investigate why it breaks when added to sources
Synesso added a commit that referenced this issue Feb 28, 2019
@Synesso
[#59] Additional headers: add them, don't with them
6b0db17
@Synesso Synesso closed this as completed Feb 28, 2019
@ire-and-curses
Copy link
Author

Wow quick work, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Synesso Synesso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Synesso @ire-and-curses