Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6074] fix message input on Desktop #6150

Merged
merged 1 commit into from
Oct 8, 2018
Merged

[#6074] fix message input on Desktop #6150

merged 1 commit into from
Oct 8, 2018

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Oct 5, 2018 •
edited by churik
Loading

fix #6074
fix #5656
fix #6153

requires changes on react-native-desktop side
https://github.com/status-im/react-native-desktop/pull/361/files

status: ready

@ghost
Copy link

ghost commented Oct 5, 2018 •
edited by rasom
Loading

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@rasom rasom changed the title fix message input on Desktop [WIP] fix message input on Desktop Oct 5, 2018
@status-comment-bot
Copy link

✅ CI BUILD SUCCESSFUL

Jenkins job: #1

Mobile
Desktop

@rasom rasom force-pushed the fix/message-input branch from 37d6a46 to 3a13eaa Compare October 5, 2018 16:03
@rasom rasom changed the title [WIP] fix message input on Desktop fix message input on Desktop Oct 5, 2018
@status-comment-bot
Copy link

✅ CI BUILD SUCCESSFUL

Jenkins job: #2

Mobile
Desktop

@statustestbot
Copy link

91% of end-end tests have passed

Total executed tests: 56
Failed tests: 5
Passed tests: 51

Failed tests (5)

Click to expand
1. test_deploy_contract_from_daap

Device 1: Tap on GotItButton
Device 1: Looking for an element by text: 'Contract deployed at: '

Contract was not created

Device sessions

2. test_public_chat_messaging

Device 2: Username is user_1 :: Golden Lumpy Mamenchisaurus
Device 1: Looking for an element by text: 'user_1'

Username 'user_1' is not shown next to the received message

Device sessions

3. test_modify_transaction_fee_values

Device 1: Tap on SignTransactionButton
Device 1: Looking for an element by text: 'intrinsic gas too low'

Device 1: 'BaseButton' is not found on the screen

Device sessions

4. test_send_eth_from_wallet_to_address

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

5. test_backup_recovery_phrase_warning_from_wallet

Device 1: Tap on HomeButton
Device 1: Wait for PlusButton

Donation was not received during 300 seconds!

Device sessions

Passed tests (51)

Click to expand
1. test_create_account
Device sessions

2. test_user_can_switch_network
Device sessions

3. test_filters_from_daap
Device sessions

4. test_copy_and_paste_messages
Device sessions

5. test_send_transaction_from_daap
Device sessions

6. test_request_and_receive_tokens_in_1_1_chat
Device sessions

7. test_delete_cut_and_paste_messages
Device sessions

8. test_offline_login
Device sessions

9. test_back_forward_buttons_browsing_website
Device sessions

10. test_password_in_logcat_sign_in
Device sessions

11. test_set_profile_picture
Device sessions

12. test_text_message_1_1_chat
Device sessions

13. test_add_to_contacts
Device sessions

14. test_unread_messages_counter_1_1_chat
Device sessions

15. test_logcat_send_transaction_from_daap
Device sessions

16. test_logcat_send_transaction_from_wallet
Device sessions

17. test_send_token_with_7_decimals
Device sessions

18. test_offline_messaging_1_1_chat
Device sessions

19. test_token_with_more_than_allowed_decimals
Device sessions

20. test_send_transaction_details_in_1_1_chat
Device sessions

21. test_manage_assets
Device sessions

22. test_wallet_set_up
Device sessions

23. test_logcat_send_transaction_in_1_1_chat
Device sessions

24. test_request_and_receive_eth_in_1_1_chat
Device sessions

25. test_swipe_to_delete_public_chat
Device sessions

26. test_send_emoji
Device sessions

27. test_add_contact_by_pasting_public_key
Device sessions

28. test_logcat_recovering_account
Device sessions

29. test_messaging_in_different_networks
Device sessions

30. test_send_tokens_in_1_1_chat
Device sessions

31. test_network_mismatch_for_send_request_commands
Device sessions

32. test_logcat_sign_message_from_daap
Device sessions

33. test_swipe_to_delete_1_1_chat
Device sessions

34. test_switch_users_and_add_new_account
Device sessions

35. test_send_stt_from_wallet
Device sessions

36. test_send_eth_in_1_1_chat
Device sessions

37. test_login_with_new_account
Device sessions

38. test_send_eth_from_wallet_to_contact
Device sessions

39. test_add_contact_from_public_chat
Device sessions

40. test_send_request_not_enabled_tokens
Device sessions

41. test_send_message_to_newly_added_contact
Device sessions

42. test_password_in_logcat_creating_account
Device sessions

43. test_backup_recovery_phrase
Device sessions

44. test_offline_status
Device sessions

45. test_open_google_com_via_open_dapp
Device sessions

46. test_unread_messages_counter_public_chat
Device sessions

47. test_sign_message_from_daap
Device sessions

48. test_share_contact_code_and_wallet_address
Device sessions

49. test_request_eth_in_wallet
Device sessions

50. test_refresh_button_browsing_app_webview
Device sessions

51. test_recover_account
Device sessions

@rasom rasom added the desktop label Oct 5, 2018
@rasom rasom self-assigned this Oct 5, 2018
@rasom
Copy link
Contributor Author

rasom commented Oct 6, 2018

wasn't able to reproduce #6153 on macos using this branch

@rasom rasom changed the title fix message input on Desktop [#6074 fix message input on Desktop Oct 6, 2018
@rasom rasom changed the title [#6074 fix message input on Desktop [#6074] fix message input on Desktop Oct 6, 2018
@churik
Copy link
Member

churik commented Oct 8, 2018

Agree that #6153 is also fixed by this issue.

Tested on both Mac OSx and Linux Ubuntu 18.04, couldn't reproduce #6074, #6153, #5656

@rasom rasom changed the title [#6074] fix message input on Desktop [DO NOT MERGE][#6074] fix message input on Desktop Oct 8, 2018
@rasom rasom added the blocked label Oct 8, 2018
@rasom rasom changed the title [DO NOT MERGE][#6074] fix message input on Desktop [#6074] fix message input on Desktop Oct 8, 2018
@rasom rasom removed the blocked label Oct 8, 2018
@rasom rasom force-pushed the fix/message-input branch from 3a13eaa to ccf037c Compare October 8, 2018 13:08
@rasom rasom merged commit ccf037c into develop Oct 8, 2018
@rasom rasom deleted the fix/message-input branch October 8, 2018 13:08
@status-comment-bot
Copy link

✅ CI BUILD SUCCESSFUL

Jenkins job: #3

Mobile
Desktop

@ilmotta ilmotta mentioned this pull request Dec 23, 2024
Merged
ilmotta added a commit that referenced this pull request Dec 27, 2024
@ilmotta
chore: Bump status-go version to include fix for bad peer check for l…
5007dc7 
…ightmode (#21865)

Upgrades status-go to version v8.0.0, which includes the fix from PR
status-im/status-go#5964 fix_: bad peer check logic for
lightmode and some fixes.

Might resolve #18031

Areas that may be impacted: we are moving from status-go version 7.0.0 to 8.0.0.
These are the changes:

- status-im/status-go@a4e36d49c * fix_: missing message verifier start-stop ,go-waku updates, lightpush service rate limits (#5964)
- status-im/status-go@810468a57 * test_: create private group tests (#6225)
- status-im/status-go@0cf556bdb * test_: unskip test initialize logging (#6229)
- status-im/status-go@b803918c2 * ci_: pytest-lint correct target pr branch (#6230)
- status-im/status-go@d29120447 * chore(block)!: remove desktop BlockContact function for parity (#6172)
- status-im/status-go@309d17ae5 * feat_: status-backend health endpoint (#6201)
- status-im/status-go@6a5623bac * test_: set proxy creds (#6211)
- status-im/status-go@2172abe95 * fix_: add infuraSecret and statusProxyBlockchainPassword to secrets (#6217)
- status-im/status-go@0f7c26dc9 * test_: skip flaky TestService_IncrementalUpdateMixed (#6205)
- status-im/status-go@75bdda271 * fix_: correct sensitive regex (#6188)
- status-im/status-go@08eee8a64 * test_: add python linters (#6212)
- status-im/status-go@66850321e * fix_: remove logging of rpc endpoint (#6195)
- status-im/status-go@c27c773c2 * chore(wallet)_: from and to chains added to send details
- status-im/status-go@74db63143 * test_: contact requests tests (#6167)
- status-im/status-go@5a8310d5a * fix(pins)_: delete pins when the og message is deleted (#6173)
- status-im/status-go@137698e02 * ci_: bring back cmd coverage (#6204)
- status-im/status-go@1795620df * test_: run functional tests on host (no container) (#6159)
- status-im/status-go@ef177c1c6 * feat_: SensitiveString type (#6190)
- status-im/status-go@8b95c8148 * feat_: graceful shutdown with status-backend (#6189)
- status-im/status-go@e6c2f89f0 * chore_: remove endpoint InitLogging (#6182)
- status-im/status-go@4ccb08f11 * test_: WalletService class (#6171)
- status-im/status-go@943ae1335 * fix(functional-tests)_: disable testnet (#6181)
- status-im/status-go@616a76098 * feat_: api logging signals (#6150)
- status-im/status-go@dfb591874 * fix_: check group error in GetBalancesAtByChain (#6169)
- status-im/status-go@3a0080281 * fix_: create/restore account error signal (#6174)
- status-im/status-go@e7cc53529 * feat(telem)_: track total waku message bandwidth (#6157)
- status-im/status-go@d07e61f61 * fix_: nil *MessengerResponse is a valid result (#6175))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenda yenda yenda approved these changes

@vitvly vitvly vitvly approved these changes

@flexsurfer flexsurfer Awaiting requested review from flexsurfer

@vkjr vkjr Awaiting requested review from vkjr

@maxhora maxhora Awaiting requested review from maxhora

Assignees

@rasom rasom

Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
7 participants
@rasom @status-comment-bot @statustestbot @churik @vitvly @yenda @751895405