bug #6135 - made place for recovery phrase error tooltip on desktop #6157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
dmitryn
approved these changes
Oct 5, 2018
flexsurfer
approved these changes
Oct 5, 2018
vitvly
approved these changes
Oct 5, 2018
goranjovic
force-pushed
the
bug/recover-validation-desktop-6135
branch
from
4a02e37 to
2fac62b
Compare
|
@goranjovic could you fix the build? |
|
no regressions on mobile , tooltips for recovery phrase are shown |
|
won't wait for autotests , this is only a UI change. Pass phrase functionality is not impacted on any platform |
Signed-off-by: Goran Jovic <[email protected]>
goranjovic
force-pushed
the
bug/recover-validation-desktop-6135
branch
from
2fac62b to
d823bfd
Compare
75% of end-end tests have passedFailed tests (15)Click to expand
Passed tests (46)Click to expand
|
ilmotta
added a commit
that referenced
this pull request
Dec 27, 2024
…ightmode (#21865) Upgrades status-go to version v8.0.0, which includes the fix from PR status-im/status-go#5964 fix_: bad peer check logic for lightmode and some fixes. Might resolve #18031 Areas that may be impacted: we are moving from status-go version 7.0.0 to 8.0.0. These are the changes: - status-im/status-go@a4e36d49c * fix_: missing message verifier start-stop ,go-waku updates, lightpush service rate limits (#5964) - status-im/status-go@810468a57 * test_: create private group tests (#6225) - status-im/status-go@0cf556bdb * test_: unskip test initialize logging (#6229) - status-im/status-go@b803918c2 * ci_: pytest-lint correct target pr branch (#6230) - status-im/status-go@d29120447 * chore(block)!: remove desktop BlockContact function for parity (#6172) - status-im/status-go@309d17ae5 * feat_: status-backend health endpoint (#6201) - status-im/status-go@6a5623bac * test_: set proxy creds (#6211) - status-im/status-go@2172abe95 * fix_: add infuraSecret and statusProxyBlockchainPassword to secrets (#6217) - status-im/status-go@0f7c26dc9 * test_: skip flaky TestService_IncrementalUpdateMixed (#6205) - status-im/status-go@75bdda271 * fix_: correct sensitive regex (#6188) - status-im/status-go@08eee8a64 * test_: add python linters (#6212) - status-im/status-go@66850321e * fix_: remove logging of rpc endpoint (#6195) - status-im/status-go@c27c773c2 * chore(wallet)_: from and to chains added to send details - status-im/status-go@74db63143 * test_: contact requests tests (#6167) - status-im/status-go@5a8310d5a * fix(pins)_: delete pins when the og message is deleted (#6173) - status-im/status-go@137698e02 * ci_: bring back cmd coverage (#6204) - status-im/status-go@1795620df * test_: run functional tests on host (no container) (#6159) - status-im/status-go@ef177c1c6 * feat_: SensitiveString type (#6190) - status-im/status-go@8b95c8148 * feat_: graceful shutdown with status-backend (#6189) - status-im/status-go@e6c2f89f0 * chore_: remove endpoint InitLogging (#6182) - status-im/status-go@4ccb08f11 * test_: WalletService class (#6171) - status-im/status-go@943ae1335 * fix(functional-tests)_: disable testnet (#6181) - status-im/status-go@616a76098 * feat_: api logging signals (#6150) - status-im/status-go@dfb591874 * fix_: check group error in GetBalancesAtByChain (#6169) - status-im/status-go@3a0080281 * fix_: create/restore account error signal (#6174) - status-im/status-go@e7cc53529 * feat(telem)_: track total waku message bandwidth (#6157) - status-im/status-go@d07e61f61 * fix_: nil *MessengerResponse is a valid result (#6175))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6135
Summary:
Moved recovery phrase input field a bit down on desktop to make place for the error tooltip
Steps to test:
see |#6135
status: ready