Upgrade react-native from 0.63.3 to 0.67.5
#15486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (84)
|
siddarthkay
changed the title
react-native from 0.63.3 to 0.67.5
siddarthkay
requested review from
yqrashawn,
rasom,
Parveshdhull,
bitgamma,
briansztamfater,
cammellos,
flexsurfer,
ilmotta,
J-Son89,
alwx,
ibrkhalil,
vkjr,
erikseppanen and
jo-mut
0% of end-end tests have passedNot executed tests (28)Failed tests (1)Click to expandClass TestActivityMultipleDevicePR:
|
briansztamfater
approved these changes
Mar 26, 2023
|
We are getting there step by step, keep up your great work! |
jo-mut
approved these changes
Mar 26, 2023
ilmotta
approved these changes
Mar 26, 2023
There was a problem hiding this comment.
The branch works well on my machine 💯 Great work @siddarthkay
|
@siddarthkay as regards expected regression, I guess it is mostly about UI (I mean message reliability should not be affected at all), right? |
|
Hi @churik : Message reliability should not be affected, I'll try sending a few messages with latest build |
Signed-off-by: Jakub Sokołowski <[email protected]>
And add deleteDebugFilesForVariant fix for libhermes. Signed-off-by: Jakub Sokołowski <[email protected]>
This elevation prop is un-necessary and causes an extra line to appear which looks like a border but its actually a shadow.
This fix was not needed in react-native 0.63.4 but is needed after we upgraded to 0.67.5
siddarthkay
force-pushed
the
react-native-0.63-to-0.67
branch
from
e097e49 to
f262c6d
Compare
This was referenced Apr 12, 2023
|
Well done dude. We'll get the eventually. |
alwx
pushed a commit
that referenced
this pull request
Apr 28, 2023
* [IOS Only] react-native 0.63 to 0.67 * [Android Only] react-native 0.63 to 0.67 * bring back all the jenkinsfiles * make auto-complete prop for text-input compatible * [IOS Only] react-native 0.63 to 0.67 * [Android Only] react-native 0.63 to 0.67 * bring back all the jenkinsfiles * nix: drop unnecessary set -x from status-go build Signed-off-by: Jakub Sokołowski <[email protected]> * add explicity implementation line for soloader And add deleteDebugFilesForVariant fix for libhermes. Signed-off-by: Jakub Sokołowski <[email protected]> * use fast-image for link previews * fix extra line in message composer on android This elevation prop is un-necessary and causes an extra line to appear which looks like a border but its actually a shadow. * don't use `fast-image` for url preview favicon * fix audio record button interfering cancel android This fix was not needed in react-native 0.63.4 but is needed after we upgraded to 0.67.5 * get rid of unused platform import --------- Co-authored-by: Jakub Sokołowski <[email protected]>
This was referenced May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades React Native from 0.63.3 to 0.67.5.
This upgrade should be treated as a stepping stone towards future upgrades.
We should have the progress merged into develop (after QA sign off) and see if this produces any unforeseen side effects while we continue the efforts to upgrade our libraries further.