Upgrade react native from 0.67.5 to 0.69.10
#16016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (146)
|
siddarthkay
requested review from
cammellos,
flexsurfer,
ilmotta,
alwx,
Parveshdhull,
J-Son89,
OmarBasem,
smohamedjavid,
ajayesivan,
rahulpsingh,
ibrkhalil,
erikseppanen,
briansztamfater and
ulisesmac
|
Awesome work @siddarthkay! Given the Porto UI fit & finish is next week I think we should avoid merging this until afterwards in case it disrupts the dev environments 👍 |
|
@J-Son89 : Sure, I agree. |
alwx
approved these changes
May 24, 2023
There was a problem hiding this comment.
Amazing job, @siddarthkay!
I saw some hacks you did (like the one in nix/deps/gradle/generate.sh), I guess the only thing is to not forget to remove those hacks once we don't need them 😅
siddarthkay
force-pushed
the
upgrade-react-native-67-to-69
branch
from
96d88bf to
de4b56c
Compare
jakubgs
requested changes
May 24, 2023
| # FIXME: Temporary fix for missing package. | ||
| echo 'org.jetbrains.kotlin.jvm:org.jetbrains.kotlin.jvm.gradle.plugin:1.6.10' >> "${DEPS_LIST}" | ||
| echo 'com.android.tools.lint:lint-gradle:30.3.0' >> "${DEPS_LIST}" | ||
| echo 'com.android.tools.build:gradle:7.0.4' >> "${DEPS_LIST}" |
There was a problem hiding this comment.
Yes, we will definitely need a proper fix for this, and theoretically that will be also a solution to this:
siddarthkay
force-pushed
the
upgrade-react-native-67-to-69
branch
from
8e99442 to
490f4fd
Compare
ajayesivan
reviewed
May 24, 2023
There was a problem hiding this comment.
iOS is working fine 🥳
On Android, I'm getting the following error when running locally,
error: builder for '/nix/store/1psjkjxd5c6icyqh4mwzfr081239z8n5-aapt2-7.3.0-8691043.drv' failed with exit code 2
error: 1 dependencies of derivation '/nix/store/gjfsvdrwb1yp0bignnpg0wdv02zxjy2l-status-mobile-maven-deps.drv' failed to build
error: build of '/nix/store/gjfsvdrwb1yp0bignnpg0wdv02zxjy2l-status-mobile-maven-deps.drv', '/nix/store/hxy6l1vz9av572hi27slv50yz258wary-status-go-0.151.15-7586452-android.drv' failed
make: *** [run-android] Error 1
0% of end-end tests have passedNot executed tests (32)Failed tests (1)Click to expandClass TestActivityMultipleDevicePR:
|
0% of end-end tests have passedFailed tests (33)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
siddarthkay
force-pushed
the
upgrade-react-native-67-to-69
branch
3 times, most recently
from
d287433 to
5bed7fd
Compare
15% of end-end tests have passedFailed tests (28)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (5)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
|
52% of end-end tests have passedFailed tests (16)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Passed tests (17)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
|
50% of end-end tests have passedFailed tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
|
|
Hi @siddarthkay, thank you for your work. No issues from my side. PR can be merged |
76% of end-end tests have passedFailed tests (8)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (25)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
|
siddarthkay
force-pushed
the
upgrade-react-native-67-to-69
branch
2 times, most recently
from
1ac5ac7 to
3b86491
Compare
siddarthkay
force-pushed
the
upgrade-react-native-67-to-69
branch
from
3b86491 to
8d42d3d
Compare
This was referenced Jun 14, 2023
codemaster115
pushed a commit
that referenced
this pull request
Jun 16, 2023
19 tasks
codemaster115
pushed a commit
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades react-native version from 0.67.5 to 0.69.10 and does what is necessary to make the upgrade happen.
This PR is yet again another stepping stone to latest version.
When this PR will be merged in we will be using a
react-nativeversion that is officially supported by Facebook's React Native team.Journey to upgrade Android Side can be seen here : #15995
Journey to upgrade IOS Side can be seen here : #15645
status: ready