Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Steps to reduce PR Android APK size #15638

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Test Steps to reduce PR Android APK size #15638

merged 1 commit into from
Apr 13, 2023

Conversation

siddarthkay
Copy link
Contributor

@siddarthkay siddarthkay commented Apr 13, 2023 •
edited
Loading

This PR adds steps to reduce the APK size which has almost doubled after the recent react-native upgrade #15486.
Android APK sizes before the react-native upgrade were below 100mb and now they are 211MB.

by adding extractNativeLibs="true" in AndroidManifest.xml we are instructing the app to compress native libs and extract them after installing the APK on device.

With this change the Android APK size dropped to 103MB.

A side effect of this may be that the app may now take more space on the device.

ref : https://developer.android.com/guide/topics/manifest/application-element#extractNativeLibs

After upgrading Android Gradle Plugin to 4.2.0 and above we must use useLegacyPackaging in our app's build.gradle
and get rid of extractNativeLibs="true" from AndroidManifest.xml

status : ready

@siddarthkay siddarthkay self-assigned this Apr 13, 2023
@siddarthkay siddarthkay linked an issue Apr 13, 2023 that may be closed by this pull request
The size of APKs is doubled #15608
Closed
@status-im-auto
Copy link
Member

status-im-auto commented Apr 13, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8585724 #1 2023-04-13 07:32:13 ~5 min android-e2e 🤖apk 📲
✔️ 8585724 #1 2023-04-13 07:32:28 ~5 min android 🤖apk 📲
✔️ 8585724 #1 2023-04-13 07:32:37 ~5 min tests 📄log
✔️ 8585724 #1 2023-04-13 07:33:46 ~7 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 910e55d #4 2023-04-13 10:35:51 ~5 min android-e2e 🤖apk 📲
✔️ 23aa8e4 #5 2023-04-13 10:42:45 ~6 min android-e2e 🤖apk 📲
✔️ 23aa8e4 #5 2023-04-13 10:42:52 ~6 min tests 📄log
✔️ 23aa8e4 #5 2023-04-13 10:43:04 ~6 min android 🤖apk 📲
✔️ 23aa8e4 #5 2023-04-13 10:43:52 ~7 min ios 📱ipa 📲

@siddarthkay siddarthkay force-pushed the reduce-pr-apk-size branch 2 times, most recently from 961ed45 to 910e55d Compare April 13, 2023 10:30
@siddarthkay
Add `extractNativeLibs' flag to reduce apk size
23aa8e4 
Android APK sizes before the react-native upgrade were below 100mb and now they are 211MB.

by adding extractNativeLibs="true" in AndroidManifest.xml we are instructing the app to compress native libs and extract them after installing the apk on device.

With this change the Android APK size dropped to 103MB.

A side effect of this may be that the app may now take more space on the device.

ref : https://developer.android.com/guide/topics/manifest/application-element#extractNativeLibs

After upgrading Android Gradle Plugin to 4.2.0 and above we must use useLegacyPackaging in our app's build.gradle
and get rid of extractNativeLibs="true" from AndroidManifest.xml
@status-im-auto
Copy link
Member

89% of end-end tests have passed

Total executed tests: 19
Failed tests: 2
Passed tests: 17
Not executed tests: 10

IDs of not executed tests: 702807,702732,702808,702846,702742,702850,702851,702936,702947,702957 

IDs of failed tests: 702958,702838

Not executed tests (10)

Click to expand
  • Rerun not executed tests

    • Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello 

    critical/test_public_chat_browsing.py:418: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:923: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

    [[blocked by 14797]]

    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: medium/test_activity_center.py:184: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
 cannot unpack non-iterable NoneType object

    [[Blocked by 15500]]

    Passed tests (17)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    @siddarthkay siddarthkay merged commit 270f5ab into develop Apr 13, 2023
    @siddarthkay siddarthkay deleted the reduce-pr-apk-size branch April 13, 2023 11:52
    alwx pushed a commit that referenced this pull request Apr 28, 2023
    @siddarthkay @alwx
    Add `extractNativeLibs' flag to reduce apk size (#15638)
    8552255
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @jakubgs jakubgs jakubgs approved these changes

    @vitvly vitvly vitvly approved these changes

    @bitgamma bitgamma Awaiting requested review from bitgamma

    @cammellos cammellos Awaiting requested review from cammellos

    Assignees

    @siddarthkay siddarthkay

    Labels
    None yet
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    The size of APKs is doubled
    5 participants
    @siddarthkay @status-im-auto @vitvly @jakubgs @J-Son89