Small mailserver async fetching refactor #5420
Conversation
Jenkins BuildsClick to see older builds (20)
|
vitvly
force-pushed
the
chore/autorequest-messages
branch
from
38a6bd0
to
ed34eec
Compare
protocol/messenger.go
Outdated
| @@ -1503,18 +1503,14 @@ func (m *Messenger) watchConnectionChange() { | |||
| // Instead we will poll the connection status. | |||
| m.logger.Warn("using WakuV1, can't watch connection changes, this might be have side-effects") | |||
| go pollConnectionStatus() | |||
| return | |||
| } | |||
| } else { | |||
There was a problem hiding this comment.
I actually think return is better comparing to else.
It's a check of err != nil, so returning makes sense there. If we will have to add more code with conditions after go subscribedConnectionStatus(subscription), the tabulation will grow to the right.
| m.logger.Error("could not perform mailserver request", zap.Error(err)) | ||
| } | ||
| }() | ||
| m.asyncRequestAllHistoricMessages() |
There was a problem hiding this comment.
asyncRequestAllHistoricMessages doesn't use performMailserverRequest.
Not sure if we want it, but noting the difference.
There was a problem hiding this comment.
Sorry, this one i don't quite understand - asyncRequestAllHistoricMessages does invoke performMailserverRequest here
status-go/protocol/messenger_mailserver.go
Line 362 in e1e04e6
There was a problem hiding this comment.
oh, I got confused
So we were calling performMailserverRequest -> RequestAllHistoricMessages -> performMailserverRequest 😵💫
I guess then it's ok now
vitvly
force-pushed
the
chore/autorequest-messages
branch
from
ed34eec
to
e1e04e6
Compare
| m.logger.Error("could not perform mailserver request", zap.Error(err)) | ||
| } | ||
| }() | ||
| m.asyncRequestAllHistoricMessages() |
There was a problem hiding this comment.
oh, I got confused
So we were calling performMailserverRequest -> RequestAllHistoricMessages -> performMailserverRequest 😵💫
I guess then it's ok now
vitvly
force-pushed
the
chore/autorequest-messages
branch
2 times, most recently
from
4b86906
to
d5bd177
Compare
vitvly
force-pushed
the
chore/autorequest-messages
branch
from
d5bd177
to
3dc67e2
Compare
Two small refactors extracted from #5292