You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But this won't fetch anything in case there was no connection state change. Moreover, this is not a pure polling mechanism, as same role is fulfilled by the code below, that utilizes waku2's ConnStatusSubscriptions.
UPDATE: clear now, the polling mechanism is only there for deprecated wakuv1. Additionally, wakuv1 also supports mailserver cycle events, that are processed when peers are updated.
So, we need a proper polling mechanism for store node messages.
Proposed solution
Write a code that will do the following every N minutes:
check if we're current in the process of fetching. If so, do nothing.
otherwise, and if last fetch time was earlier than N minutes, start fetching.
Provide a user-configurable setting for N.
Chore: drop waku1 code from Messenger.watchConnectionChange().
Problem
We need to fetch messages periodically from store nodes.
Currently this is done by
status-go/protocol/messenger.go
Line 928 in dfdc165
which is periodically invoked from
Messenger.watchConnectionChange()
:status-go/protocol/messenger.go
Line 1447 in dfdc165
But this won't fetch anything in case there was no connection state change. Moreover, this is not a pure polling mechanism, as same role is fulfilled by the code below, that utilizes waku2's
ConnStatusSubscription
s.UPDATE: clear now, the
polling
mechanism is only there for deprecated wakuv1. Additionally, wakuv1 also supportsmailserver cycle events
, that are processed when peers are updated.So, we need a proper polling mechanism for store node messages.
Proposed solution
N
.Messenger.watchConnectionChange()
.cc @churik @cammellos
The text was updated successfully, but these errors were encountered: