Scheduled store node fetches #5292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (36)
|
vitvly
force-pushed
the
fix/store-periodic-fetching
branch
5 times, most recently
from
3724e2b
to
0930bf6
Compare
vitvly
force-pushed
the
fix/store-periodic-fetching
branch
from
5a00be3
to
46be469
Compare
|
Closing, some bits extracted into #5420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5283
Description
Messenger.asyncRequestAllHistoricMessages()is replaced byMessenger.startStoreNodeFetchLoop()Messenger.storeSchedulerChthat is read from by the loop abovestatus-go/protocol/messenger_mailserver_cycle.go
Line 432 in 631b1af
RequestAllHistoricMessages(false, false)withperformMailserverRequest, if same functionality is achieved withRequestAllHistoricMessages(false, true). So this was removed