Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: anotate deprecate all providers deployContract #408

Merged
merged 1 commit into from
Nov 22, 2022
Merged

fix: anotate deprecate all providers deployContract #408

merged 1 commit into from
Nov 22, 2022

Conversation

tabaktoni
Copy link
Collaborator

Motivation and Resolution

Deprecate all providers deployContract in preparation to removal

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes
  • Updated the docs (www)
  • Updated the tests
  • All tests are passing

@netlify
Copy link

netlify bot commented Nov 22, 2022 •
edited
Loading

✅ Deploy Preview for starknetjs canceled.

Name Link
🔨 Latest commit 65eed1f
🔍 Latest deploy log https://app.netlify.com/sites/starknetjs/deploys/637c8c2664e1120008efa121

@tabaktoni tabaktoni merged commit 0e00459 into develop Nov 22, 2022
@tabaktoni tabaktoni deleted the fix/deprecate-deployContract branch March 30, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivpavici ivpavici ivpavici approved these changes

@dhruvkelawala dhruvkelawala Awaiting requested review from dhruvkelawala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tabaktoni @ivpavici