Skip to content

Commit

Permalink
Merge pull request #408 from 0xs34n/fix/deprecate-deployContract
Browse files Browse the repository at this point in the history
fix: anotate deprecate all providers deployContract
  • Loading branch information
tabaktoni authored Nov 22, 2022
2 parents e3eaf2e + 65eed1f commit 0e00459
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 1 deletion.
3 changes: 3 additions & 0 deletions src/provider/default.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ export class Provider implements ProviderInterface {
return this.provider.invokeFunction(functionInvocation, details);
}

/**
* @deprecated This method won't be supported, use Account.deploy instead
*/
public async deployContract(
payload: DeployContractPayload,
details: InvocationsDetails
Expand Down
2 changes: 2 additions & 0 deletions src/provider/interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ export abstract class ProviderInterface {
/**
* Deploys a given compiled contract (json) to starknet
*
* @deprecated This method won't be supported, use Account.deploy instead
*
* @param payload payload to be deployed containing:
* - compiled contract code
* - constructor calldata
Expand Down
2 changes: 1 addition & 1 deletion src/provider/rpc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ export class RpcProvider implements ProviderInterface {
}

/**
* @deprecated This method wont be supported soon, use Account.deploy instead
* @deprecated This method won't be supported, use Account.deploy instead
*/
public async deployContract(
{ contract, constructorCalldata, addressSalt }: DeployContractPayload,
Expand Down
3 changes: 3 additions & 0 deletions src/provider/sequencer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,9 @@ export class SequencerProvider implements ProviderInterface {
}).then(this.responseParser.parseInvokeFunctionResponse);
}

/**
* @deprecated This method won't be supported, use Account.deploy instead
*/
public async deployContract({
contract,
constructorCalldata,
Expand Down

0 comments on commit 0e00459

Please sign in to comment.