Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: anotate deprecate all providers deployContract #408

Merged
merged 1 commit into from
Nov 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/provider/default.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,9 @@ export class Provider implements ProviderInterface {
return this.provider.invokeFunction(functionInvocation, details);
}

/**
* @deprecated This method won't be supported, use Account.deploy instead
*/
public async deployContract(
payload: DeployContractPayload,
details: InvocationsDetails
Expand Down
2 changes: 2 additions & 0 deletions src/provider/interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ export abstract class ProviderInterface {
/**
* Deploys a given compiled contract (json) to starknet
*
* @deprecated This method won't be supported, use Account.deploy instead
*
* @param payload payload to be deployed containing:
* - compiled contract code
* - constructor calldata
Expand Down
2 changes: 1 addition & 1 deletion src/provider/rpc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ export class RpcProvider implements ProviderInterface {
}

/**
* @deprecated This method wont be supported soon, use Account.deploy instead
* @deprecated This method won't be supported, use Account.deploy instead
*/
public async deployContract(
{ contract, constructorCalldata, addressSalt }: DeployContractPayload,
Expand Down
3 changes: 3 additions & 0 deletions src/provider/sequencer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,9 @@ export class SequencerProvider implements ProviderInterface {
}).then(this.responseParser.parseInvokeFunctionResponse);
}

/**
* @deprecated This method won't be supported, use Account.deploy instead
*/
public async deployContract({
contract,
constructorCalldata,
Expand Down