Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2022 12 12.1.b7b15aa #662

Merged
merged 16 commits into from
Dec 12, 2022
Merged

Conversation

kovayur
Copy link
Contributor

@kovayur kovayur commented Dec 12, 2022

Description

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Evaluated and added CHANGELOG.md entry if required
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

kovayur and others added 16 commits December 7, 2022 13:26
* ROX-13593: Add tenant ID as a k8s label

The tenant ID may be used to query tenant resources in scripts and tooling. In addition, the tenant ID identifies the Segment group for telemetry users.

* fix style after rebase

* add tenant id to namespace label
Do return error when check fails 🤦.
In addition to labelling the Central CR (see pull/627), this applies the labels to resources managed by the ACS operator.
…656)

Revert "Rollback automatic tag resolution on prod (#645)"

This reverts commit 1847f55.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, vladbologa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur merged commit 0d628ef into production Dec 12, 2022
@kovayur kovayur deleted the release-2022-12-12.1.b7b15aa branch December 12, 2022 13:50
@kovayur kovayur restored the release-2022-12-12.1.b7b15aa branch December 12, 2022 14:15
@kovayur kovayur deleted the release-2022-12-12.1.b7b15aa branch December 12, 2022 15:46
kovayur added a commit that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants