Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-13648: check out full history #647

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

porridge
Copy link
Collaborator

@porridge porridge commented Dec 7, 2022

Description

The ability to see at least some history is crucial for the logic in terraforming script which selects the commit from which to retrieve the id to use as the image tag name.

It's easier to just fetch the whole history than to come up with some arbitrary threshold number.
Relevant section of docs for the checkout action.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Evaluated and added CHANGELOG.md entry if required
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

No real way to test this. 😢

@porridge porridge requested a review from kovayur December 7, 2022 10:53
@openshift-ci openshift-ci bot added the approved label Dec 7, 2022
@@ -30,6 +30,8 @@ jobs:
go-version: "1.18"
- name: Checkout
uses: actions/checkout@v3
with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this for stage?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking we don't, but I'd really like to keep differences between stage and prod to absolutely necessary minimum. Let me add a comment.

@kovayur
Copy link
Contributor

kovayur commented Dec 7, 2022

No real way to test this. 😢

Can we at least create a test branch X, add some simple GH workflow there and merge branch Y into X to ensure that the problematic git command is executed as intended?

UPD: Or maybe just push changes to trigger the test workflow, without merging

@porridge
Copy link
Collaborator Author

porridge commented Dec 8, 2022

No real way to test this. cry

Can we at least create a test branch X, add some simple GH workflow there and merge branch Y into X to ensure that the problematic git command is executed as intended?

  • Run on a linear history, shows the hash returned matches HEAD
  • Run on a merge commit, shows the hash returned matches the dummy commit id. We were even lucky to have GitHub create another merge commit on top, to keep in sync with the PR base :-)

@porridge
Copy link
Collaborator Author

porridge commented Dec 8, 2022

/retest

@porridge porridge mentioned this pull request Dec 8, 2022
Copy link
Contributor

@kovayur kovayur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, special thanks for performing tests.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, porridge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@porridge porridge merged commit 2826f61 into main Dec 8, 2022
@porridge porridge deleted the porridge/ROX-13648-no-shallow-repo branch December 8, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants