-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-13648: check out full history #647
Conversation
@@ -30,6 +30,8 @@ jobs: | |||
go-version: "1.18" | |||
- name: Checkout | |||
uses: actions/checkout@v3 | |||
with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this for stage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking we don't, but I'd really like to keep differences between stage and prod to absolutely necessary minimum. Let me add a comment.
Can we at least create a test branch X, add some simple GH workflow there and merge branch Y into X to ensure that the problematic UPD: Or maybe just push changes to trigger the test workflow, without merging |
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, special thanks for performing tests.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur, porridge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
The ability to see at least some history is crucial for the logic in terraforming script which selects the commit from which to retrieve the id to use as the image tag name.
It's easier to just fetch the whole history than to come up with some arbitrary threshold number.
Relevant section of docs for the checkout action.
Checklist (Definition of Done)
Unit and integration tests addedAdded test description underTest manual
ROX-12345: ...
Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Test manual
No real way to test this. 😢