Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-13648: check out full history #647

Merged
merged 1 commit into from
Dec 8, 2022
Merged

ROX-13648: check out full history #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/deploy-production.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ jobs:
go-version: "1.18"
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0 # Critical for correct image detection in deploy script
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1-node16
with:
Expand Down Expand Up @@ -58,6 +60,8 @@ jobs:
go-version: "1.18"
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0 # Critical for correct image detection in deploy script
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1-node16
with:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/deploy-stage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ jobs:
go-version: "1.18"
- name: Checkout
uses: actions/checkout@v3
with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this for stage?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking we don't, but I'd really like to keep differences between stage and prod to absolutely necessary minimum. Let me add a comment.

fetch-depth: 0 # Critical for correct image detection in deploy script
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1-node16
with:
Expand Down Expand Up @@ -58,6 +60,8 @@ jobs:
go-version: "1.18"
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0 # Critical for correct image detection in deploy script
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1-node16
with:
Expand Down