Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused RDS code #642

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Remove unused RDS code #642

merged 1 commit into from
Dec 7, 2022

Conversation

vladbologa
Copy link
Contributor

Description

Checklist (Definition of Done)

- [ ] Unit and integration tests added
- [ ] Added test description under Test manual
- [ ] Evaluated and added CHANGELOG.md entry if required
- [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)

  • CI and all relevant tests are passing
    - [ ] Add the ticket number to the PR title if available, i.e. ROX-12345: ...
    - [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.

Test manual

CI is sufficient.

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@openshift-ci openshift-ci bot added the approved label Dec 6, 2022
@vladbologa vladbologa requested review from kovayur and ebensh December 6, 2022 18:40
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, vladbologa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vladbologa vladbologa merged commit f4e727b into main Dec 7, 2022
@vladbologa vladbologa deleted the vbologa/remove-unused-code branch December 7, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants