Prefactor: extract central CR removal reconciliation to dedicated function in fleetshard central reconciler

[rhybrillou]

Description

Checklist (Definition of Done)

• Unit and integration tests added
• Added test description under Test manual
• Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
• CI and all relevant tests are passing
• Add the ticket number to the PR title if available, i.e. ROX-12345: ...
• Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
• Add secret to app-interface Vault or Secrets Manager if necessary

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[rhybrillou]

Current dependencies on/for this PR:

• main
  • PR Prefactor: extract status collection to dedicated function in fleetshard central reconciler #1052
    • PR Prefactor: extract auth provider reconciliation to dedicated function in fleetshard central reconciler #1053
      • PR Prefactor: extract central CR reconciliation to dedicated function in fleetshard central reconciler #1054
        • PR Prefactor: extract central DB reconciliation to dedicated function in fleetshard central reconciler #1055
          • PR Prefactor: extract central CR removal reconciliation to dedicated function in fleetshard central reconciler #1056 👈
            • PR Prefactor: extract auth provider configuration reconciliation to dedicated function in fleetshard central reconciler #1057
              • PR Prefactor: extract central CR definition creation to dedicated function in fleetshard central reconciler #1058
                • PR ROX-16734: Reconcile Central Audit log notifier configuration #1041

This comment was auto-generated by Graphite.

[SimonBaeumer]

.

[SimonBaeumer]

Suggested change

	func (r *CentralReconciler) reconcileInstanceDeletion(ctx context.Context, remoteCentral private.ManagedCentral, central *v1alpha1.Central) (*private.DataPlaneCentralStatus, error) {
	func (r *CentralReconciler) reconcileInstanceDeletion(ctx context.Context, remoteCentral *private.ManagedCentral, central *v1alpha1.Central) (*private.DataPlaneCentralStatus, error) {

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhybrillou, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SimonBaeumer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment