Prefactor: Make steps more explicit in fleetshard reconciler loop #1040
Conversation
|
Skipping CI for Draft Pull Request. |
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
| @@ -3,6 +3,7 @@ package reconciler | |||
| import "github.com/pkg/errors" | |||
|
|
|||
| var ( | |||
| errInvalidArguments = errors.New("invalid arguments") | |||
There was a problem hiding this comment.
Why do we not reuse errox package here, we already have the import of stackrox 🤔
| } | ||
|
|
||
| if r.managedDBEnabled { | ||
| if err = r.reconcileCentralDBConfig(ctx, remoteCentral, central); err != nil { |
There was a problem hiding this comment.
Applies to all resources that you change: pass a pointer here instead of the struct, otherwise changes won't be applied.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaus67, rhybrillou, SimonBaeumer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Minor refactor in fleetshard: extract functions to reduce the size of the central reconciler function.
Checklist (Definition of Done)
- [ ] Unit and integration tests addedTest manual- [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)- [ ] Add the ticket number to the PR title if available, i.e.ROX-12345: ...Test manual
TODO: Add manual testing efforts