Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefactor: extract status collection to dedicated function in fleetshard central reconciler #1052

Merged

Conversation

rhybrillou
Copy link
Contributor

Description

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development
make verify lint binary test test/integration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhybrillou rhybrillou temporarily deployed to development May 25, 2023 11:11 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development May 25, 2023 11:11 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development May 25, 2023 11:11 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhybrillou, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhybrillou, SimonBaeumer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

New changes are detected. LGTM label has been removed.

@rhybrillou rhybrillou temporarily deployed to development June 12, 2023 16:30 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development June 12, 2023 16:30 — with GitHub Actions Inactive
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

New changes are detected. LGTM label has been removed.

@rhybrillou rhybrillou force-pushed the yann/prefactor_restructure_reconcile_loop_status_collection branch from 21e5bad to 2f4544b Compare June 12, 2023 17:46
@rhybrillou rhybrillou temporarily deployed to development June 12, 2023 17:46 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development June 12, 2023 17:46 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development June 12, 2023 17:46 — with GitHub Actions Inactive
@rhybrillou rhybrillou marked this pull request as ready for review June 13, 2023 08:02
@rhybrillou rhybrillou temporarily deployed to development June 13, 2023 08:03 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development June 13, 2023 08:03 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development June 13, 2023 08:03 — with GitHub Actions Inactive
@rhybrillou rhybrillou force-pushed the yann/prefactor_restructure_reconcile_loop_status_collection branch from 2f4544b to ca6e2b8 Compare June 13, 2023 08:35
@rhybrillou rhybrillou temporarily deployed to development June 13, 2023 08:35 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development June 13, 2023 08:35 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development June 13, 2023 08:35 — with GitHub Actions Inactive
@rhybrillou
Copy link
Contributor Author

/retest

@rhybrillou rhybrillou force-pushed the yann/prefactor_restructure_reconcile_loop_status_collection branch from ca6e2b8 to b920c95 Compare June 19, 2023 09:53
@rhybrillou rhybrillou temporarily deployed to development June 19, 2023 09:53 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development June 19, 2023 09:53 — with GitHub Actions Inactive
@rhybrillou rhybrillou temporarily deployed to development June 19, 2023 09:53 — with GitHub Actions Inactive
@rhybrillou
Copy link
Contributor Author

/test e2e

@rhybrillou rhybrillou merged commit 5ca7d77 into main Jun 19, 2023
@rhybrillou rhybrillou deleted the yann/prefactor_restructure_reconcile_loop_status_collection branch June 19, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants