Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/kubernetes): clean up console noise in tests #7794

Merged
merged 2 commits into from
Jan 22, 2020
Merged

fix(core/kubernetes): clean up console noise in tests #7794

merged 2 commits into from
Jan 22, 2020

Conversation

anotherchrisberry
Copy link
Contributor

Still tracking down one of the noisy ones...

Before
Screen Shot 2020-01-21 at 4 08 24 PM

After
Screen Shot 2020-01-21 at 4 32 02 PM

Copy link
Contributor

@louisjimenez louisjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this out with the manifest editor 👍

@anotherchrisberry anotherchrisberry merged commit 05c93f4 into spinnaker:master Jan 22, 2020
@anotherchrisberry anotherchrisberry deleted the test-output-cleanup branch January 22, 2020 17:25
jervi added a commit to jervi/deck that referenced this pull request Jan 31, 2020
b51dce4 chore(lint): Run eslint on typescript files
05c93f4 fix(core/kubernetes): clean up console noise in tests (spinnaker#7794)
e6c6c66 refactor(*): de-angularize confirmationModalService (spinnaker#7759)
eef40f6 fix(kubernetes): remove accidental static from resolveIndexedSecurityGroups (spinnaker#7760)
10b3491 refactor(*): use consistent styles on modal headers
a59b2c3 refactor(core): convert confirmation modal to react
6548872 refactor(core): provide wrapper for dangerously setting html (spinnaker#7721)
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants