fix(core/kubernetes): clean up console noise in tests (#7794)

spinnaker · Jan 22, 2020 · 05c93f4 · 05c93f4
1 parent ddb1790
commit 05c93f4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/app/scripts/modules/core/src/plugins/plugin.registry.spec.ts b/app/scripts/modules/core/src/plugins/plugin.registry.spec.ts
@@ -58,6 +58,7 @@ describe('PluginRegistry', () => {
 
     it('should return a rejected promise if a loaded module doesnt contain an export named plugin', async () => {
       loadModuleFromUrlSpy.and.callFake(fakePromise({}));
+      spyOn(console, 'error').and.stub();
       const plugin1 = { name: 'foo', version: '1.0.0' };
       pluginRegistry.register(plugin1);
 

diff --git a/app/scripts/modules/core/src/presentation/forms/inputs/JsonEditor.tsx b/app/scripts/modules/core/src/presentation/forms/inputs/JsonEditor.tsx
@@ -51,6 +51,13 @@ export class JsonEditor extends React.Component<IJsonEditorProps> {
   }
 
   public render() {
-    return <AceEditor {...this.props} ref={this.editorRef} onValidate={this.validate} />;
+    return (
+      <AceEditor
+        {...this.props}
+        ref={this.editorRef}
+        onValidate={this.validate}
+        editorProps={{ $blockScrolling: Infinity }}
+      />
+    );
   }
 }
diff --git a/app/scripts/modules/kubernetes/src/v2/manifest/editor/json/JsonEditor.tsx b/app/scripts/modules/kubernetes/src/v2/manifest/editor/json/JsonEditor.tsx
@@ -49,6 +49,7 @@ export class JsonEditor extends React.Component<IJsonEditorProps> {
           showLineNumbers: false,
           showFoldWidgets: false,
         }}
+        editorProps={{ $blockScrolling: Infinity }}
         className="ace-editor"
       />
     );