fix(kubernetes): remove accidental static from resolveIndexedSecurity… #7760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jervi
added a commit
to jervi/deck
that referenced
this pull request
Jan 31, 2020
b51dce4 chore(lint): Run eslint on typescript files 05c93f4 fix(core/kubernetes): clean up console noise in tests (spinnaker#7794) e6c6c66 refactor(*): de-angularize confirmationModalService (spinnaker#7759) eef40f6 fix(kubernetes): remove accidental static from resolveIndexedSecurityGroups (spinnaker#7760) 10b3491 refactor(*): use consistent styles on modal headers a59b2c3 refactor(core): convert confirmation modal to react 6548872 refactor(core): provide wrapper for dangerously setting html (spinnaker#7721)
|
@spinnakerbot cherry-pick 1.17 |
spinnakerbot
pushed a commit
that referenced
this pull request
Mar 4, 2020
|
Cherry pick successful: #7999 |
ezimanyi
added a commit
that referenced
this pull request
Mar 4, 2020
…Groups (#7760) (#7999) Co-authored-by: Maggie Neterval <[email protected]>
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Groups
Partially addresses spinnaker/spinnaker#5068
I added a bad
static! Unfortunately, removing it does not resolve spinnaker/spinnaker#5068 because we are still unable to resolveKubernetesSecurityGroupReaderhere, because we are not attachingkuberneteson each security group under any of the permitted keys (provider,cloudProvider,type). I tried running Deck at its 1.12.14 commit, when this was known to work, to ensure that it was in fact Clouddriver's responsibility to pass one of those fields along. Corresponding Clouddriver PR coming soon...