-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx 5.1.0 exception: pop from an empty deque #10701
Comments
@eivindjahren I can't install ERT on Windows to reproduce (Python 3.9; pip 22.2):
Any suggestions? A |
@AA-Turner unfortunately we don't support windows. I am guessing the problem is that it's not finding a windows wheel for ecl. |
sphinx-5.1.0 broke our build. Issue raised here: sphinx-doc/sphinx#10701. Pinning for now.
seems due to
so adding dummy docstring to those properties worksaround the issue edit: a quick dirty monkey patching workaround https://github.com/datalad/datalad/pull/6883/files#diff-008dcb3426febd767787b1521f1fe33086313b927ea37eaab86df5fa88a51698R356 with hope that 5.1.1 will soon fix this issue properly. |
See sphinx-doc/sphinx#10701 for more information. I have not checked if rendered docs are anyhow affected etc. I hope the issue would get fixed asap since should affect lots of sphinx users
Same issue with Spack: https://readthedocs.org/projects/spack/builds/17523257/ |
Similar error on essentially blank project following guide from https://py-pkgs.org/ |
|
sphinx-5.1.0 broke our build. Issue raised here: sphinx-doc/sphinx#10701. Pinning for now.
I experience the same issue in my GH actions run: https://github.com/tue-robotics/tue-robotics.github.io/runs/7493639327?check_suite_focus=true#step:4:47 |
add workaround of @yarikoptic to conf.py for Sphinx 5.1.0
add workaround of @yarikoptic to conf.py for Sphinx 5.1.0 fixes #2224
Due to sphinx-doc/sphinx#10701 documentation build of dpctl started failing with release of Sphinx 5.1.0. The exception raised is triggered by missing docstrings for property class attributes. This change adds such docstrings and now local documentation build goes through as expected.
docs: workaround for sphinx-doc/sphinx#10701
#10709 seems to address the issue in testing. I guess my concern is that no unit tests caught this scenario, so i'm curious if that's something that could be added to ensure we don't see a reoccurrence if the implementation is changed in the future |
Sphinx 5.1.1 has been released, see #10710. A |
https://www.sphinx-doc.org/en/master/changes.html doesn't actually list the changes in 5.1.1 |
You're too quick for CI, the website is currently rendering! A |
Issue is resolved on our end 🥳 ! Thanks for the help @AA-Turner ! |
Happy to report my Azure DevOps docs builds are passing again now that Sphinx 5.1.1 is being picked up. Thanks for fixing this so quickly, @AA-Turner! |
For me, too. Thanks! |
sphinx-doc/sphinx#10701 is fixed (cherry picked from commit e9f2a2b)
sphinx-doc/sphinx#10701 is fixed (cherry picked from commit e9f2a2b) Co-authored-by: Luciano Bello <[email protected]>
Describe the bug
As of 5.1.0 our doc build at github.com/equinor/ert stopped working and gives us the following unhandled exception:
How to Reproduce
Following works in my environment, if there are issues, see https://github.com/equinor/ert/blob/ec015e87ef511f45826ae53c0aae1d6e1a99b9f1/.github/workflows/build.yml#L195 for how its
done in CI.
Expected behavior
Documentation is built
Your project
github.com/equinor/ert
Screenshots
No response
OS
Ubuntu-latest
Python version
3.8
Sphinx version
5.1.0
Sphinx extensions
"sphinx.ext.intersphinx", "sphinx.ext.mathjax", "sphinx.ext.ifconfig", "sphinx.ext.githubpages", "sphinx.ext.autodoc", "sphinx.ext.napoleon", "sphinxarg.ext", "sphinx.ext.todo", "sphinxcontrib.datatemplates",
Extra tools
No response
Additional context
Our project uses some custom plugins, and we are trying to figure out if they are acting up.
The text was updated successfully, but these errors were encountered: