Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcm structure change #322

Merged
merged 17 commits into from
Jul 26, 2022
Merged

tcm structure change #322

merged 17 commits into from
Jul 26, 2022

Conversation

jasondet
Copy link
Collaborator

Before submitting a pull request, please make sure you've read and understood
pygama developer's
guide
. In
particular, do not forget to:

  • Update existing or add new tests
  • Update existing or add new documentation
  • Address any issue reported by GitHub bots

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #322 (91fafe0) into main (16a3246) will decrease coverage by 0.16%.
The diff coverage is 13.55%.

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
- Coverage   33.10%   32.93%   -0.17%     
==========================================
  Files          73       73              
  Lines        6187     6242      +55     
==========================================
+ Hits         2048     2056       +8     
- Misses       4139     4186      +47     
Impacted Files Coverage Δ
src/pygama/evt/build_tcm.py 0.00% <0.00%> (ø)
src/pygama/evt/tcm.py 0.00% <0.00%> (ø)
src/pygama/math/histogram.py 7.56% <0.00%> (ø)
src/pygama/math/utils.py 14.84% <0.00%> (-0.48%) ⬇️
src/pygama/lgdo/vectorofvectors.py 60.16% <16.32%> (-29.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a3246...91fafe0. Read the comment docs.

@jasondet
Copy link
Collaborator Author

The build_documentation failure is a sphinx bug as reported in earlier PRs, merging...

@jasondet jasondet merged commit efd34cc into legend-exp:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants