-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vis
cleanup
#312
vis
cleanup
#312
Conversation
gipert
commented
Jul 9, 2022
- type hints and docstring updates
- basic WaveformBrowser test
Codecov Report
@@ Coverage Diff @@
## main #312 +/- ##
===========================================
+ Coverage 33.10% 45.32% +12.22%
===========================================
Files 73 73
Lines 6187 6186 -1
===========================================
+ Hits 2048 2804 +756
+ Misses 4139 3382 -757
Continue to review full report at Codecov.
|
Does this overlap with PR 310? Also, should be on main not refactor. |
@iguinn also please review this one. |
I reviewed the annotations and comment changes to waveform_browser, and aside from the comment it looks good to me. |
Co-authored-by: Ian Guinn <[email protected]>
The build_documentation failure is a sphinx-doc/sphinx#10701. I have turned off this requirement for merging and will merge. |