Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vis cleanup #312

Merged
merged 11 commits into from
Jul 26, 2022
Merged

vis cleanup #312

merged 11 commits into from
Jul 26, 2022

Conversation

gipert
Copy link
Member

@gipert gipert commented Jul 9, 2022

  • type hints and docstring updates
  • basic WaveformBrowser test

@gipert gipert requested a review from iguinn July 9, 2022 10:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2022

Codecov Report

Merging #312 (7f2c80d) into main (16a3246) will increase coverage by 12.22%.
The diff coverage is 77.27%.

@@             Coverage Diff             @@
##             main     #312       +/-   ##
===========================================
+ Coverage   33.10%   45.32%   +12.22%     
===========================================
  Files          73       73               
  Lines        6187     6186        -1     
===========================================
+ Hits         2048     2804      +756     
+ Misses       4139     3382      -757     
Impacted Files Coverage Δ
src/pygama/vis/waveform_browser.py 67.39% <76.19%> (+67.39%) ⬆️
src/pygama/vis/__init__.py 100.00% <100.00%> (+100.00%) ⬆️
src/pygama/lgdo/lh5_store.py 76.92% <0.00%> (+1.13%) ⬆️
src/pygama/lgdo/table.py 95.31% <0.00%> (+1.56%) ⬆️
src/pygama/dsp/_processors/convolutions.py 6.97% <0.00%> (+6.97%) ⬆️
src/pygama/lgdo/waveform_table.py 88.00% <0.00%> (+7.00%) ⬆️
src/pygama/dsp/_processors/gaussian_filter1d.py 10.34% <0.00%> (+10.34%) ⬆️
src/pygama/dsp/_processors/wiener_filter.py 11.11% <0.00%> (+11.11%) ⬆️
src/pygama/dsp/_processors/trap_filters.py 12.50% <0.00%> (+12.50%) ⬆️
.../pygama/dsp/_processors/get_multi_local_extrema.py 12.82% <0.00%> (+12.82%) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a3246...7f2c80d. Read the comment docs.

@jasondet
Copy link
Collaborator

Does this overlap with PR 310?

Also, should be on main not refactor.

@jasondet jasondet changed the base branch from refactor to main July 21, 2022 00:17
@jasondet
Copy link
Collaborator

@iguinn also please review this one.

@iguinn
Copy link
Collaborator

iguinn commented Jul 21, 2022

I reviewed the annotations and comment changes to waveform_browser, and aside from the comment it looks good to me.

@jasondet
Copy link
Collaborator

@gipert can you check why Build documentation is failing? I couldn't figure it out from the Details.

@jasondet
Copy link
Collaborator

The build_documentation failure is a sphinx-doc/sphinx#10701. I have turned off this requirement for merging and will merge.

@jasondet jasondet merged commit d7fb068 into legend-exp:main Jul 26, 2022
@gipert gipert deleted the vis branch August 10, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants