-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threading revamp: add ThreadContext and remove Dataflow usage #400
Open
adamhathcock
wants to merge
202
commits into
dev
Choose a base branch
from
remove-dataflow
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,352
−1,886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dev: moves pointcloud converter to top level (#349)
* dev: Fixed autocad async (#370) chore: comments fix: allows pre-transformation of all ITransformable objects adds a setting to send rebars as line or solid (#367) Update SDK and dependencies (#366) Jrm/parameter extraction (#365) dogukan/cnx-753-normals-are-flipped (#364) Dogukan/cnx 691 extract appropriate class properties by type (#352) Revit async fix for sending (#362) feat: adds top level converter for railings dogukan/cnx-748-send-grids-from-tekla (#353) fix: adds built in category for setting ds cat on receive reliably feat: CXPLA-120 Added tekla zip packaging prior to installers (#357) add appId (#358) adds logic for rendering rebars as lines and arcs (#356) Fixed test failing on german culture (#355) CNX-501 Temp folder arcgis (#351) receive operation fix (#350)
- Added `DisplayValueExtractor` class for extracting display values from Navisworks model items - Added `GeometryToSpeckleConverter` class for converting Navisworks geometry to Speckle SDK models - Updated dependencies in `NavisworksConverterServiceRegistration.cs` to include the new classes
This commit renames the file GeomtryNodeMerger.cs to GeometryNodeMerger.cs.
- Updated NavisworksSelectionBinding to include IElementSelectionService as a dependency in the constructor. - Updated NavisworksSendBinding to include IElementSelectionService as a dependency in the constructor. - Removed ElementSelectionExtension.cs file. - Added ElementSelectionService.cs file which includes methods for getting model item path, resolving model item from path, checking visibility of model items, and getting geometry nodes.
* Clean up projects and locks for all Navisworks * Fix nuget error * Fixed Local SLN and removed some runtime IDs * add back RuntimeIdentifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces ThreadContext to centrally manage threading across host apps. Most are UI/Worker based but exceptions are noted here:
https://www.notion.so/speckle/Threading-In-Host-Apps-14ab78fc7aa6807ca052c6c0869530d2