fix(revit): handles plane origin out of bounds and creating group with no elements exceptions #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p when no objects have been successfully converted also makes room display values transparent
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #346 +/- ##
========================================
- Coverage 8.48% 8.44% -0.04%
========================================
Files 237 237
Lines 4642 4663 +21
Branches 514 514
========================================
Hits 394 394
- Misses 4232 4253 +21
Partials 16 16 ☔ View full report in Codecov by Sentry. |
AlanRynne
requested changes
Nov 5, 2024
Comment on lines
+28
to
+29
| if (_elementIdsForTopLevelGroup.Count == 0) | ||
| // if no elements were successfully converted, instead of throwing when creating a new group, we should just return and let object conversion exceptions bubble up. |
There was a problem hiding this comment.
You may need to walk me through this
| @@ -209,4 +213,21 @@ private bool SkipGeometry(DB.GeometryObject geomObj, DB.Element element) | |||
|
|
|||
| return false; | |||
| } | |||
|
|
|||
| // Determines if an element should be sent with invisible display values | |||
| private bool SetElementDisplayToTransparent(DB.Element element) | |||
There was a problem hiding this comment.
Naming is a bit confusing, could be ShouldSetElement... instead?
Current seems to imply the method does in fact set something.
| @@ -8,13 +8,25 @@ | |||
| namespace Speckle.Converters.RevitShared.ToSpeckle; | |||
|
|
|||
| public class MeshByMaterialDictionaryToSpeckle | |||
| : ITypedConverter<(Dictionary<DB.ElementId, List<DB.Mesh>> target, DB.ElementId parentElementId), List<SOG.Mesh>> | |||
| : ITypedConverter< | |||
| (Dictionary<DB.ElementId, List<DB.Mesh>> target, DB.ElementId parentElementId, bool makeTransparent), | |||
There was a problem hiding this comment.
We really should have a type for this tuple 🙂
…nt-is-required-parameter-name
AlanRynne
approved these changes
Nov 5, 2024
AlanRynne
deleted the
claire/cnx-709-civil2revit-at-least-one-element-is-required-parameter-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(exceptions)
before:
after:
(rooms)
before:
https://latest.speckle.systems/projects/3f895e614f/models/a78e96e0a8@1b0859bb04
after:
https://latest.speckle.systems/projects/3f895e614f/models/a78e96e0a8@347cd6f726