Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revit async fix for sending #362

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Revit async fix for sending #362

merged 6 commits into from
Nov 7, 2024

Conversation

adamhathcock
Copy link
Member

Models what happened for receive

fix for category being null and tryget

@adamhathcock adamhathcock enabled auto-merge (squash) November 6, 2024 19:40
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 8.40%. Comparing base (5f4eebe) to head (dc12f03).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ToSpeckle/Parameters/ParameterDefinitionHandler.cs 0.00% 1 Missing ⚠️
...hared/ToSpeckle/Raw/MaterialQuantitiesToSpeckle.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #362   +/-   ##
=====================================
  Coverage   8.40%   8.40%           
=====================================
  Files        238     238           
  Lines       4689    4688    -1     
  Branches     514     514           
=====================================
  Hits         394     394           
+ Misses      4279    4278    -1     
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan JR-Morgan self-requested a review November 7, 2024 09:34
@adamhathcock adamhathcock merged commit 35d8c41 into dev Nov 7, 2024
5 checks passed
@adamhathcock adamhathcock deleted the revit-async-fix branch November 7, 2024 09:37
jsdbroughton added a commit that referenced this pull request Nov 8, 2024
* dev:
  Fixed autocad async (#370)
  chore: comments
  fix: allows pre-transformation of all ITransformable objects
  adds a setting to send rebars as line or solid (#367)
  Update SDK and dependencies (#366)
  Jrm/parameter extraction (#365)
  dogukan/cnx-753-normals-are-flipped (#364)
  Dogukan/cnx 691 extract appropriate class properties by type (#352)
  Revit async fix for sending (#362)
  feat: adds top level converter for railings
  dogukan/cnx-748-send-grids-from-tekla (#353)
  fix: adds built in category for setting ds cat on receive reliably
  feat: CXPLA-120 Added tekla zip packaging prior to installers (#357)
  add appId (#358)
  adds logic for rendering rebars as lines and arcs (#356)
  Fixed test failing on german culture (#355)
  CNX-501 Temp folder arcgis (#351)
  receive operation fix (#350)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants