Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify DI/assembly structure part deux #270

Merged
merged 35 commits into from
Sep 24, 2024

Conversation

adamhathcock
Copy link
Member

Retry of #256

Adds fallback handling which Revit needed

Copy link

linear bot commented Sep 24, 2024

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 26.27119% with 87 lines in your changes missing coverage. Please review.

Project coverage is 8.46%. Comparing base (c805ff0) to head (1917336).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ckle.Converters.RevitShared/ServiceRegistration.cs 0.00% 23 Missing ⚠️
...I3/Speckle.Connectors.DUI/ContainerRegistration.cs 0.00% 17 Missing ⚠️
...ckle.Converters.RhinoShared/ServiceRegistration.cs 0.00% 9 Missing ⚠️
...3/Speckle.Connectors.DUI/Bindings/ConfigBinding.cs 0.00% 8 Missing ⚠️
...Speckle.Connectors.Common/ContainerRegistration.cs 0.00% 7 Missing ⚠️
...RhinoShared/ToHost/Raw/PolyCurveToHostConverter.cs 0.00% 6 Missing ⚠️
...hared/ToSpeckle/Raw/PolyCurveToSpeckleConverter.cs 0.00% 5 Missing ⚠️
Sdk/Speckle.Connectors.Common/Connector.cs 0.00% 3 Missing ⚠️
...verters.RevitShared/RevitRootToSpeckleConverter.cs 0.00% 2 Missing ⚠️
...rs.DUI/Bindings/TopLevelExceptionHandlerBinding.cs 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #270      +/-   ##
========================================
+ Coverage   7.80%   8.46%   +0.65%     
========================================
  Files        236     236              
  Lines       4520    4549      +29     
  Branches     544     548       +4     
========================================
+ Hits         353     385      +32     
+ Misses      4151    4147       -4     
- Partials      16      17       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock enabled auto-merge (squash) September 24, 2024 13:12
Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@adamhathcock adamhathcock merged commit 3227d09 into dev Sep 24, 2024
5 checks passed
@adamhathcock adamhathcock deleted the adam/cxpla-15-simplify-assembly-structure branch September 24, 2024 13:15
@didimitrie
Copy link
Member

in adam and manual testing we trust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants