Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify DI assembly structure #256

Merged
merged 27 commits into from
Sep 23, 2024

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Sep 19, 2024

Remove Autofac dependency.
Removing extra DI and assembles in favor of direct references.
Reworked some dependencies
S.Connectors.Utils -> S.Connectors.Common

[x] Rhino
[x] Revit
[ ] ArcGIS
[x] Autocad

also https://linear.app/speckle/issue/CXPLA-12/autofac-registration-syntax

Copy link

linear bot commented Sep 19, 2024

@adamhathcock adamhathcock changed the title Adam/cxpla 15 simplify assembly structure Simplify DI assembly structure Sep 19, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 9.27835% with 88 lines in your changes missing coverage. Please review.

Project coverage is 7.87%. Comparing base (e1e7626) to head (70b4f64).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ckle.Converters.RevitShared/ServiceRegistration.cs 0.00% 22 Missing ⚠️
...I3/Speckle.Connectors.DUI/ContainerRegistration.cs 0.00% 17 Missing ⚠️
...ckle.Converters.RhinoShared/ServiceRegistration.cs 0.00% 9 Missing ⚠️
...3/Speckle.Connectors.DUI/Bindings/ConfigBinding.cs 0.00% 8 Missing ⚠️
...Speckle.Connectors.Common/ContainerRegistration.cs 0.00% 7 Missing ⚠️
...RhinoShared/ToHost/Raw/PolyCurveToHostConverter.cs 0.00% 6 Missing ⚠️
...Converters.Common/Registration/ConverterManager.cs 0.00% 5 Missing ⚠️
Sdk/Speckle.Connectors.Common/Connector.cs 0.00% 3 Missing ⚠️
...verters.RevitShared/RevitRootToSpeckleConverter.cs 0.00% 2 Missing ⚠️
...rs.DUI/Bindings/TopLevelExceptionHandlerBinding.cs 0.00% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #256   +/-   ##
=====================================
  Coverage   7.86%   7.87%           
=====================================
  Files        235     234    -1     
  Lines       4477    4472    -5     
  Branches     523     525    +2     
=====================================
  Hits         352     352           
+ Misses      4110    4105    -5     
  Partials      15      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock marked this pull request as ready for review September 20, 2024 08:02
Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Also tested in autocad with no errors :)

@adamhathcock adamhathcock merged commit 7307e83 into dev Sep 23, 2024
5 checks passed
@adamhathcock adamhathcock deleted the adam/cxpla-15-simplify-assembly-structure branch September 23, 2024 14:27
@adamhathcock adamhathcock restored the adam/cxpla-15-simplify-assembly-structure branch September 23, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants