Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify DI/assembly structure part deux #270

Merged
merged 35 commits into from
Sep 24, 2024

resolve circular dep with lazy get

1917336
Select commit
Loading
Failed to load commit list.
Merged

Simplify DI/assembly structure part deux #270

resolve circular dep with lazy get
1917336
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 24, 2024 in 0s

8.46% (+0.65%) compared to c805ff0

View this Pull Request on Codecov

8.46% (+0.65%) compared to c805ff0

Details

Codecov Report

Attention: Patch coverage is 26.27119% with 87 lines in your changes missing coverage. Please review.

Project coverage is 8.46%. Comparing base (c805ff0) to head (1917336).

Files with missing lines Patch % Lines
...ckle.Converters.RevitShared/ServiceRegistration.cs 0.00% 23 Missing ⚠️
...I3/Speckle.Connectors.DUI/ContainerRegistration.cs 0.00% 17 Missing ⚠️
...ckle.Converters.RhinoShared/ServiceRegistration.cs 0.00% 9 Missing ⚠️
...3/Speckle.Connectors.DUI/Bindings/ConfigBinding.cs 0.00% 8 Missing ⚠️
...Speckle.Connectors.Common/ContainerRegistration.cs 0.00% 7 Missing ⚠️
...RhinoShared/ToHost/Raw/PolyCurveToHostConverter.cs 0.00% 6 Missing ⚠️
...hared/ToSpeckle/Raw/PolyCurveToSpeckleConverter.cs 0.00% 5 Missing ⚠️
Sdk/Speckle.Connectors.Common/Connector.cs 0.00% 3 Missing ⚠️
...verters.RevitShared/RevitRootToSpeckleConverter.cs 0.00% 2 Missing ⚠️
...rs.DUI/Bindings/TopLevelExceptionHandlerBinding.cs 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files 
@@           Coverage Diff            @@
##             dev    #270      +/-   ##
========================================
+ Coverage   7.80%   8.46%   +0.65%     
========================================
  Files        236     236              
  Lines       4520    4549      +29     
  Branches     544     548       +4     
========================================
+ Hits         353     385      +32     
+ Misses      4151    4147       -4     
- Partials      16      17       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov