Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WHATWG boilerplate #1155

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented Dec 18, 2017

This uses the computed metadata features to set better defaults across all WHATWG standards, and moves certain scripts (including the service worker registration script) into the boilerplate.

As a drive-by, it removes the "likely out-of-date" for translations as it turns out we have very responsive translators for WHATWG standards and we'd like to be a bit nicer about their work.

domenic added a commit to whatwg/url that referenced this pull request Dec 18, 2017
See https://blog.whatwg.org/copyright-license-change for the former and
whatwg/meta#23 plus
speced/bikeshed#1155 for the latter. The new
boilerplate includes the new copyright license, so this commit just
removes it from the source file, as it does many other things that are
now deduplicated into the Bikeshed boilerplate.
@domenic domenic force-pushed the new-whatwg-boilerplates branch 2 times, most recently from 84b50fc to db980d5 Compare December 19, 2017 16:13
@domenic
Copy link
Collaborator Author

domenic commented Dec 19, 2017

Please DO NOT MERGE until we get whatwg/sg#51 resolved, as otherwise all WHATWG spec builds will start failing. The plan was to land this then land a bunch of PRs similar to whatwg/url#360 in quick succession. But until whatwg/sg#51 is resolved those PRs are blocked, and so this one is too.

I'll ping the thread once it's ready!

@domenic
Copy link
Collaborator Author

domenic commented Jan 2, 2018

@annevk I think this is ready. Let me know if it looks good to you; if so I'll send PRs like this to every other Bikeshed-using WHATWG spec, and then we can get the Bikeshed PR merged, and then merge these PRs, and everything will be nice.

@domenic
Copy link
Collaborator Author

domenic commented Jan 2, 2018

Er, I meant to actually ping you to take a look at whatwg/url#360, @annevk. Sorry about that.

This uses the computed metadata features to set better defaults across all WHATWG standards, and moves certain scripts (including the service worker registration script) into the boilerplate.

As a drive-by, it removes the "likely out-of-date" for translations as it turns out we have very responsive translators for WHATWG standards and we'd like to be a bit nicer about their work.
@domenic
Copy link
Collaborator Author

domenic commented Jan 4, 2018

I got alphabetically down to Quirks before being called away to dinner. Quirks has some small issues as well: whatwg/quirks#20. Storage, Streams, URL, and XHR remain.

@domenic
Copy link
Collaborator Author

domenic commented Jan 4, 2018

All PRs are ready. Things that would be nice to fix, but will not completely break things if they are done later:

@domenic
Copy link
Collaborator Author

domenic commented Jan 4, 2018

OK, merge at will!

@tabatkins tabatkins merged commit 778c811 into speced:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants