Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: use new WHATWG boilerplate and license #132

Merged
merged 5 commits into from
Jan 9, 2018
Merged

Conversation

domenic
Copy link
Member

@domenic domenic commented Jan 3, 2018

Do not merge until speced/bikeshed#1155 is merged.


Preview | Diff

annevk
annevk previously requested changes Jan 4, 2018
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this leaves associated resources in an unclear state.

@annevk
Copy link
Member

annevk commented Jan 4, 2018

See whatwg/sg#48.

@domenic
Copy link
Member Author

domenic commented Jan 5, 2018

I mean, should we block all further development on encoding until that gets resolved, or what? I don't see how this PR makes anything worse, just better.

@annevk
Copy link
Member

annevk commented Jan 6, 2018

I added a commit that makes the additional changes that will likely satisfy the requirements. Review appreciated. The final commit message probably needs to be revised and should mention whatwg/meta#65 as I've tackled that here as well.

@annevk annevk dismissed their stale review January 7, 2018 11:19

stale

@annevk
Copy link
Member

annevk commented Jan 7, 2018

@domenic could you have a final look?

@domenic
Copy link
Member Author

domenic commented Jan 8, 2018

LGTM!

@annevk annevk merged commit d55cb85 into master Jan 9, 2018
@annevk annevk deleted the new-boilerplate branch January 9, 2018 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants