Meta: use new WHATWG boilerplate and license #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
approved these changes
Jan 4, 2018
| !Commits: <a href="https://twitter.com/notifyapi">@notifyapi</a> | ||
| !Tests: <a href=https://github.com/w3c/web-platform-tests/tree/master/notifications>web-platform-tests notifications/</a> (<a href=https://github.com/w3c/web-platform-tests/labels/notifications>ongoing work</a>) | ||
| !Translation (non-normative): <span title="Simplified Chinese"><a href=https://w3c-html-ig-zh.github.io/notifications/whatwg/ lang=zh hreflang=zh rel=alternate>简体中文</a></span> | ||
| Translation: zh-cn https://w3c-html-ig-zh.github.io/notifications/whatwg/ |
There was a problem hiding this comment.
Is a more specific code better? (The resource itself seems to declare "en"...)
There was a problem hiding this comment.
In this case yes, as zh-cn is specifically Simplified Chinese (which the resource is). It might be good to file an issue on the resource to update its language code, indeed.
There was a problem hiding this comment.
https://github.com/w3c-html-ig-zh/notifications has no way to file issues (and also seems like it's not actively maintained).
There was a problem hiding this comment.
I'll leave it for now, on the logic that separate translation changes should stay separate.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until speced/bikeshed#1155 is merged.
Preview | Diff