Define parameters as a structure #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arametersSchema The getRule method could be then simplified, too. See phpstan/phpstan#10223
spaze
pushed a commit
to francescolaffi/phpstan-disallowed-calls
that referenced
this pull request
Dec 12, 2023
spaze
added a commit
that referenced
this pull request
Dec 13, 2023
|
Released in 3.0.0. |
spaze
added a commit
that referenced
this pull request
Feb 13, 2024
PHPStan 1.10.58 updated nette/di from v3.1.5 to v3.1.10 and possibly that's the reason why `::constant` is not accepted anymore. phpstan/phpstan-src#2907 The config file is tested so even if the value of the constant would change, however unlikely, it would be detected by failing tests. Close #249 Introduced in #222 as a fix for phpstan/phpstan#10223
spaze
added a commit
that referenced
this pull request
Feb 13, 2024
…fig (#250) PHPStan 1.10.58 updated nette/di from v3.1.5 to v3.1.10 and possibly that's the reason why `::constant` is not accepted anymore. phpstan/phpstan-src#2907 The config file is tested so even if the value of the constant would change, however unlikely, it would be detected by failing tests. Close #249 Introduced in #222 as a fix for phpstan/phpstan#10223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #192
Follow-up bug fixes #229 #231