Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension parameters in extension.neon should be defined as a structure #192

Closed
spaze opened this issue Apr 30, 2023 · 1 comment · Fixed by #222
Closed

Extension parameters in extension.neon should be defined as a structure #192

spaze opened this issue Apr 30, 2023 · 1 comment · Fixed by #222
Labels
enhancement New feature or request

Comments

@spaze
Copy link
Owner

spaze commented Apr 30, 2023 •
edited
Loading

To allow for typo checking etc.:

phpstan-disallowed-calls/extension.neon

Lines 14 to 16 in 3dfc371

# These should be defined using `structure` with listed keys but it seems to me that PHPStan requires
# all keys to be present in a structure but `message` & `allow*`/`disallow*` are optional.
disallowedNamespaces: listOf(

This is now possible by prepending the key name with ?, starting with phpstan/phpstan-src#1686 (comment)
@spaze spaze added the enhancement New feature or request label Apr 30, 2023
@spaze
Copy link
Owner Author

spaze commented Nov 29, 2023

Currently blocked by phpstan/phpstan#10223

spaze added a commit that referenced this issue Nov 29, 2023
@spaze
Define parameters as a structure
f18b5ed 
Close #192
@spaze spaze mentioned this issue Nov 29, 2023
Merged
spaze added a commit that referenced this issue Nov 30, 2023
@spaze
Define parameters as a structure (#222)
f940bc8 
Close #192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define parameters as a structure spaze/phpstan-disallowed-calls
1 participant
@spaze