-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disallowed-loose-calls.neon
broke with PHPStan 1.10.58
#249
Comments
Because I run `composer update` in PHP workflow, it should help detect things like #249 earlier.
PHPStan 1.10.58 updated nette/di from v3.1.5 to v3.1.10 and possibly that's the reason why ::constant is not accepted anymore. phpstan/phpstan-src#2907 The config file is tested so even if the value of the constant would change, however unlikely, it would be detected by failing tests. Close #249
PHPStan 1.10.58 updated nette/di from v3.1.5 to v3.1.10 and possibly that's the reason why `::constant` is not accepted anymore. phpstan/phpstan-src#2907 The config file is tested so even if the value of the constant would change, however unlikely, it would be detected by failing tests. Close #249 Introduced in #222 as a fix for phpstan/phpstan#10223
…fig (#250) PHPStan 1.10.58 updated nette/di from v3.1.5 to v3.1.10 and possibly that's the reason why `::constant` is not accepted anymore. phpstan/phpstan-src#2907 The config file is tested so even if the value of the constant would change, however unlikely, it would be detected by failing tests. Close #249 Introduced in #222 as a fix for phpstan/phpstan#10223
Because I run `composer update` in PHP workflow, it should help detect things like #249 earlier.
Because I run `composer update` in PHP workflow, it should help detect things like #249 earlier.
Hi, thanks. I've changed the config file and added scheduled tests so next time I could detect it hopefully before you do 😅 The fix is in just released 3.1.2. FYI @ondrejmirtes, re the
I think it just did :-) But I'm fine with that. |
I've tried reverting It might make this work again. |
Yeah, thanks, it started working again, but I'll leave it that way just in case it will stop working again one day 😅 (note to self: basically the same problem reported in phpstan/phpstan#10727) |
The other 3 work fine, but including this one with PHPStan 1.10.58 will break it. Will work fine with PHPStan 1.10.57. Tested with v3.1.1 through PHP 8.2 and 8.3.
Broken:
Also broken:
Works fine:
Also works fine:
The text was updated successfully, but these errors were encountered: