Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Fixes dump header on different symfony versions #177

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

nunomaduro
Copy link
Collaborator

@nunomaduro nunomaduro commented Jan 12, 2024

This pull request addresses the issue in #175. The solution involves setting the dump header property to an empty string without utilizing a property. In Symfony 7, this property is typed, whereas in Symfony 6, it is not.

Ideally, this should be tagged as hot-fix.

@nunomaduro nunomaduro requested a review from freekmurze January 12, 2024 12:48
@freekmurze freekmurze merged commit 005e1e7 into main Jan 12, 2024
66 checks passed
@freekmurze
Copy link
Member

Thanks!

@freekmurze freekmurze deleted the fix/dump-header branch January 12, 2024 13:15
renovate bot referenced this pull request in RadioRoster/backend Feb 10, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [spatie/laravel-ignition](https://flareapp.io/ignition)
([source](https://togithub.com/spatie/laravel-ignition)) | `2.3.2` ->
`2.4.1` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/spatie%2flaravel-ignition/2.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/spatie%2flaravel-ignition/2.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/spatie%2flaravel-ignition/2.3.2/2.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/spatie%2flaravel-ignition/2.3.2/2.4.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>spatie/laravel-ignition (spatie/laravel-ignition)</summary>

###
[`v2.4.1`](https://togithub.com/spatie/laravel-ignition/blob/HEAD/CHANGELOG.md#241---2024-01-12)

[Compare
Source](https://togithub.com/spatie/laravel-ignition/compare/2.4.0...2.4.1)

##### What's Changed

- \[2.x] Fixes dump header on different symfony versions by
[@&#8203;nunomaduro](https://togithub.com/nunomaduro) in
[https://github.com/spatie/laravel-ignition/pull/177](https://togithub.com/spatie/laravel-ignition/pull/177)

**Full Changelog**:
spatie/laravel-ignition@2.4.0...2.4.1

###
[`v2.4.0`](https://togithub.com/spatie/laravel-ignition/blob/HEAD/CHANGELOG.md#240---2024-01-04)

[Compare
Source](https://togithub.com/spatie/laravel-ignition/compare/2.3.3...2.4.0)

##### What's Changed

- \[2.x] Adds L11 support by
[@&#8203;nunomaduro](https://togithub.com/nunomaduro) in
[https://github.com/spatie/laravel-ignition/pull/167](https://togithub.com/spatie/laravel-ignition/pull/167)

##### New Contributors

- [@&#8203;nunomaduro](https://togithub.com/nunomaduro) made their first
contribution in
[https://github.com/spatie/laravel-ignition/pull/167](https://togithub.com/spatie/laravel-ignition/pull/167)

**Full Changelog**:
spatie/laravel-ignition@2.3.3...2.4.0

###
[`v2.3.3`](https://togithub.com/spatie/laravel-ignition/blob/HEAD/CHANGELOG.md#233---2023-12-21)

[Compare
Source](https://togithub.com/spatie/laravel-ignition/compare/2.3.2...2.3.3)

-   decode job payload data if it is a string

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/RadioRoster/backend).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants