Merge pull request #177 from spatie/fix/dump-header

[2.x] Fixes dump header on different symfony versions
spatie · Jan 12, 2024 · 005e1e7 · 005e1e7
2 parents 7430569 + 8c52639
commit 005e1e7
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/Recorders/DumpRecorder/HtmlDumper.php b/src/Recorders/DumpRecorder/HtmlDumper.php
@@ -8,7 +8,12 @@
 
 class HtmlDumper extends BaseHtmlDumper
 {
-    protected $dumpHeader = '';
+    public function __construct($output = null, string $charset = null, int $flags = 0)
+    {
+        parent::__construct($output, $charset, $flags);
+
+        $this->setDumpHeader('');
+    }
 
     public function dumpVariable($variable): string
     {

diff --git a/tests/Recorders/DumpRecorder/HtmlDumperTest.php b/tests/Recorders/DumpRecorder/HtmlDumperTest.php
@@ -0,0 +1,9 @@
+<?php
+
+use Spatie\LaravelIgnition\Recorders\DumpRecorder\HtmlDumper;
+
+it('has an empty string as dump header', function () {
+    $dumpHeader = (fn () => $this->getDumpHeader())->call(new HtmlDumper);
+
+    expect($dumpHeader)->toBe('');
+});