Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HtmlDumper::$dumpHeader is not compatible with symfony's $dumpHeader. #175

Closed
nshiro opened this issue Jan 9, 2024 · 1 comment
Closed

HtmlDumper::$dumpHeader is not compatible with symfony's $dumpHeader. #175

nshiro opened this issue Jan 9, 2024 · 1 comment
Assignees
@timvandijck

Comments

@nshiro
Copy link

nshiro commented Jan 9, 2024

Symfony added types to public and protected properties in v7.0.2.
symfony/var-dumper@2964058#diff-3ecbc1b7f995db6056ace83cf869b5440d6877e462c768a35bcb6acf77df6d0bR62

And we now get this error message with symfony v7.
Type of Spatie\LaravelIgnition\Recorders\DumpRecorder\HtmlDumper::$dumpHeader must be ?string (as in class Symfony\Component\VarDumper\Dumper\HtmlDumper)

I'm not sure what the best solution is.
So I just submitted the issue.
@buismaarten buismaarten mentioned this issue Jan 11, 2024
Closed
@nunomaduro nunomaduro mentioned this issue Jan 12, 2024
Merged
@freekmurze
Copy link
Member

This is fixed in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timvandijck timvandijck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: HtmlDumper::$dumpHeader is not compatible with symfony's $dumpHeader
3 participants
@freekmurze @timvandijck @nshiro