Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink DOIs to preferred resolver #562

Merged
merged 1 commit into from
Oct 27, 2018
Merged

Hyperlink DOIs to preferred resolver #562

merged 1 commit into from
Oct 27, 2018

Conversation

katrinleinweber
Copy link
Contributor

@katrinleinweber katrinleinweber commented Oct 27, 2018

Same as dib-lab/khmer#1881 ;-)

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Oct 27, 2018

Codecov Report

Merging #562 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #562   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files          25       25           
  Lines        3543     3543           
  Branches       37       37           
=======================================
  Hits         3136     3136           
  Misses        407      407

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb323f...8150f35. Read the comment docs.

@luizirber luizirber merged commit d2e2e3f into sourmash-bio:master Oct 27, 2018
@luizirber
Copy link
Member

Thanks @katrinleinweber!

@katrinleinweber
Copy link
Contributor Author

You're welcome, and thanks for merging :-)

ctb added a commit that referenced this pull request Dec 12, 2018
* a trial refactoring of the lca db

* save and load seem to basically work

* got search & gather on LCA working in new framework

* allow key error

* keep identities with no lineage assigment

* add multigather

* Hyperlink DOIs to preferred resolver (#562)

* fix divide by zero issue in MinHash.contained_by (#572)

* fix divide by zero issue in contained_by

* remove unused lineages and identifiers

* update report output

* majority of lca tests passing now!

* fix gather?

* ...all tests pass?
bluegenes pushed a commit that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants