Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink DOIs to preferred resolver #1881

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Hyperlink DOIs to preferred resolver #1881

merged 2 commits into from
Feb 13, 2019

Conversation

katrinleinweber
Copy link
Contributor

Hello :-)

The DOI foundation recommends this new resolver. Yes, a bit ironic that they would change the URL of their service, but it's now encrypted. Because the old links with the dx subdomain continue to work, there is no urgent need to do anything.

However, I'd hereby like to suggest to follow the new recommendation and update all static DOI links.

Cheers!

PS: I think the below template doesn't really fit in this case, because no functionality at all is touched, and no text either.


Message from the khmer maintainers:

Please provide a description of the pull request above, including a
reasonable level of detail and references to any relevant threads. After
creating the pull request, complete and mark the checklist below. If any item
is not applicable, feel free to remove it or mark it as complete. If you are
unsure about any item, feel free to ask about it before or during code
review.

When you are ready for the pull request to be reviewed, please post a comment
with a message such as "Ready for review!"

  • Is any new functionality in tested? (This can be checked with
    make clean diff-cover or the CodeCov report that is automatically
    generated following a successful CI build.)
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Have any changes to the command-line interface been explicitly described?
    Only backwards-compatible additions are allowed without a major version
    increment. Changing file formats also requires a major version number
    increment.
  • Have any substantial changes been documented in CHANGELOG.md? See
    keepachangelog for more details.
  • Do the changes respect streaming I/O? (Are they tested for streaming I/O?)

@katrinleinweber
Copy link
Contributor Author

Ready for review!

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #1881 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1881   +/-   ##
======================================
  Coverage    0.01%   0.01%           
======================================
  Files          78      78           
  Lines       33208   33208           
  Branches      434     434           
======================================
  Hits            5       5           
  Misses      33203   33203
Impacted Files Coverage Δ
khmer/khmer_args.py 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f49568...ccbe7a8. Read the comment docs.

Copy link
Member

@standage standage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And sorry for the delay in troubleshooting our CI build.

@standage standage merged commit 55ec12a into dib-lab:master Feb 13, 2019
@katrinleinweber
Copy link
Contributor Author

No problem. You're welcome, and thanks for merging :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants