Compatibility issues with SOUP #361
Comments
|
Thanks @IzzySoft. I will try getting it to work with SOUP as soon as possible. I will also look into making the access token only necessary if it's, well, necessary! :P |
|
@IzzySoft Could I check which userscript manager you're using, and which browser? It seems to be working with Chrome/Tampermonkey for me? |
|
Good old GreaseMonkey (not the WebExt one) on good old Waterfox. I refuse throwing away my environment just because Mozilla thinks so. |
|
@IzzySoft We don't really support GM anymore because it was getting quite hard to make it work with all the changes but if it's the old version it should still work :/ If you see the dialog, can you enable debugging then check the console? |
|
Can do that tomorrow on the machine where I have it running. What exactly shall I test then (e.g. what colliding scripts shall I enable)? |
|
@IzzySoft The main one would be SOUP if you can. The other scripts just conflict with specific features which I can fix, but its the main SOUP bug that breaks the entire script that I need to fix first! |
|
As requested, just cross-checked with SOUP enabled/disabled. With SOUP enabled ("z1.txt"): Same page with SOUP disabled ("z2.txt"): For your convenience, the diff between the two: Funny things (was the script updated – or is it just that I now have it run on a different post?):
I've re-enabled SOUP now to see what works. A quick check confirms at least several SOX features are working: mentioned reply links, comment of edits, author names on comments in the inbox, tags on answers in search, display name next to gravatar, sticky upvote/downvote (though the upvote is hidden behind the MetaCollider™ aka "top bar", which might well be due to some UserStyles I use), meta+chat links on hover in network list, scroll-to-top button. Things I could test if I knew where include spoilers. I also couldn't figure how to "paste images directly". Forgive me for whatever I forgot to check … and let me know what else you want checked. In case things might have got working due to disabled features of SOX (and not due to fresh page or browser restart), here's a fresh list of … Features Enabled |
|
@IzzySoft Thank you (nice touch with the diff!), I will look into this this week! It's weird how SOUP isn't completely breaking SOX now, I hope it was a one-off! To paste an image, ideally just pressing Ctrl+V in a comment/post edit textarea should add a link to the image. I've found (at least on Windows) that sometimes just opening an image and copying it doesn't fully work -- opening snipping tool and making a mini capture always automatically copies it to the clipboard though! |
I hope the breaking was 😉
OK, but what to have in the clipboard for that? An URL to the image? A local path to it? The image itself? The last part of your last comment suggests the latter, which didn't work for me last time. Got to try that again, now that the other stuff magically started working. PS: Just tested again. Didn't work with the image in clipboard (nothing happened on Ctrl-V) or with the URL in the clipboard (just pasted the URL itself). |
|
@IzzySoft Please could you install dev 2.2.37. For the pasting images, the image should be in the clipboard. Please can you check if anything appears in the console when you press Ctrl+V? Also, please could you check the 'network' tab of the developer tools (if you open it after the page has loaded it will be empty to start with). This GIF should show you what you're looking for: I haven't installed those other scripts yet, but I'll get to them soon! |
|
Thanks, I can check when I'm back at the machine where I have SOX running – but that will take about 2 weeks. Five hours earlier, and I could have checked immediately … Please ping me again if you haven't heard back from me until September 20th 😉 |
|
That's no problem! Sorry it wasn't earlier!
|
|
I've also fixed the clash with the kbd, sup, sub userscript in dev 2.2.38 -- if that script is installed, SOX will just not show the KBD button :) Also, I don't think there should be a clash with AutoReviewComments because SOX doesn't really have a feature that adds comments (I think... 😆 there's so many 😝) |
shu8
added a commit
that referenced
this issue
Sep 2, 2018
* new dev * #305 * #307 * #310 * #310 * Better fix for #310 The old fix placed the SOX button to the right of the username, but the username only shows up in the top bar if you're logged in. This meant the SOX button would be absent if you were logged out. This new code should fix that. * #310 * #309, #313 * #311, #312 * #256 * #319, #317, #316 * #256 * #318 * #294 deprecate enhanced editor * #308, other small fixes * #320 * minor fixes (#324) change scroll top top feature JSON info * fixes #329 (#330) also reduces jQuery dependency * v2.1.4 DEV before push to master also adds #326 * v2.2.0 * inital DEV push * update readme to state GM not supported; #306 * reduce dependency on `hotkeys`+minor details (#333) * #334 fixed * #334 * #334 * #338 * #335, #338 * Micro optimizations (#336) * update source link * micro optimizations - converted jQuery .not to CSS selector for faster perf (https://stackoverflow.com/questions/8845811/performance-differences-between-using-not-and-not-selectors) - introduced a separate function to eliminate thrice-repeated (!) code, to keep it DRY * fixes some issues (#339) described in #338 (comment) * fixes #338 * fixes #338 (#340) 1. used addEventListener instead of onload 2. descriptive names (`reader`) 3. optimized extraction of the image URL from the `data` 4. made all declarations `var` and moved them into one place for consistency 5. shortened the POST url to simply `'/upload/image?https=true',` ;P * #322 implemented * Sticky property * Update sox.user.js * Updating button colors The main SE buttons use a lighter color than the SOX buttons * Update sox.css * Minor fixes Patched a problem with vote buttons, and fixed the color of the notify on edit button * Update sox.user.js * minor changes/fixes * #341 temporary fix * Updated mod diamond icon Updated to the icon, to match the one used by the new topbar * Updated diamond icon * Updated mod diamond * improvements in colorAnswerer (#344) * improvements in colorAnswerer 1. constant variables+cache answeredID 2. reduce jQuery dependency+shorter a[href] selector via user ID 3. change coloration * optimization: use filters throughout (#345) reduces bandwidth consumption * fixes a few features; adds CSS Fixes moveBounty, dragBounty, copyCommentsLink. Adds class for colorAnswerer. Updates jQuery * fixes quickAuthorInfo fontawesome icon * fix a few of #308 * Major improvements in code extensibility, reduced API usage, eliminate redundancy, etc. (#348) * fixes various bugs mentioned in #348 * fixes standOutDupeCloseMigrated for search pages * remove unwanted console logs * #347, various minor tweaks * fixes small bug in parseCrossSiteLinks e.g. on this comment: https://meta.stackoverflow.com/questions/370902/i-need-a-lot-of-help-to-write-a-query-for-the-stack-exchange-data-explorer-sh?cb=1#comment608548_370902 * Fixed Meta SE's chat link Added a / to the end of Meta SE's if statement to fix it. Also replaced "discuss" with "meta" for Area 51 (to match the new URL for Area 51 Discussions), shortened a bit of code, and added some comments * Fixed Meta SE links * Changed topbar z-index Changed the fixed topbar's z-index to match the one on SO, in order to prevent elements like the usercard (z-index: 1000) from covering it * Made it clearer what the checkbox does * Many fixes to dialog buttons Fixes many of the bugs from #308 * Many fixes to dialog buttons Fixes many of the bugs from #308 * Many fixes to dialog buttons Fixes many of the bugs from #308 * Many fixes to dialog buttons Fixes many of the bugs from #308 * Fixed Area 51 Discussions bug * #348 minor tweak * fix (#350) ...for answerer ID 13 also matching commenter ids beginning with 13 (1345, 13555, etc.) * #352, #353 remove yahoo YQL use * #352 * PR/351 (#355) * update getQuestionTags * provide immediate response to user * minor changes * #325: remove rangyInputs dependency (#354) * bump version number * remove downvotedPostsEditAlert; remove rangyinputs `require`; implement mini changelog in dialog * install stale and no-response bots * #356 added, minor bug fix * start #349, start to move to es6 * onlyShowCommentActionsOnHover bug fix * #357 * deprecate fixedTopbar feature for #349 * add showTagWikiLinkOnTagPopup feature * #359 fixed * #358 fixed * fixes #360 * fixes for #361 * #361 changes * v2.3.0 final
shu8
added a commit
that referenced
this issue
Sep 22, 2018
|
@IzzySoft I've just pushed an update, dev 2.3.7, to stop forcing you to get an access token! Please give it a shot :) |
|
Bang! Shot it to the machine where I hadn't yet installed it. Got the prompt, denied it. On a first glance, looks OK (too early to give a definite answer on that part). One thing, though: SOX uses an "remote font" for the item in the MetaCollider™ toolbar ("soxSettingsButton"). I refuse to enable remote fonts, as according to uBlock Origin some are loaded from Google, others from FontAwesome (couldn't find a reference in your code, though – so that could be from some SE code) – which makes it look strange (a box for "unknown character"). Just found it with FF's "inspect element": the font used is "Font Awesome 5 Free". Could you use a local font source for that? Same issue for the "jump to top" floating button, btw. |
|
@IzzySoft that's great! There is a chance we can start using SVGs but we use fontawesome in quite a few different places throughout the script so it won't be easy :/ I'll see what I can do. |
|
Thanks a lot! Keep in mind that's "cosmetical" as long as one uses uBlock Origin (or some other way to block remote fonts). As I do so, I don't expect you to have it fixed this evening 🤣 But I really appreciate your care for it. |
|
@IzzySoft Added an answer to the original meta question now :) No problem! I hope you find SOX useful! If you see any other problems, please could you open another issue? (I think the main problems have been fixed for this one! 🎉) |
|
Upvoted and accepted :) And yes, new issue coming – though I cannot tell for sure before the font issue has been solved. Speaking of which: shall I make a separate issue for "remote font removal" as well? |
|
Thanks! A separate issue would help as I could add it in the change log if
I manage to do it!!
I probably won't get a chance till next weekend though, sorry!
…On Fri, 28 Sep 2018, 22:35 Izzy, ***@***.***> wrote:
Upvoted and accepted :) And yes, new issue coming – though I cannot tell
for sure before the font issue has been solved. Speaking of which: shall I
make a separate issue for "remote font removal" as well?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#361 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIcNjr-jldh3y6lsyXCj2wUNBg4O5syYks5ufpYHgaJpZM4WJiUi>
.
|
shu8
added a commit
that referenced
this issue
Feb 3, 2019
* new dev * #305 * #307 * #310 * #310 * Better fix for #310 The old fix placed the SOX button to the right of the username, but the username only shows up in the top bar if you're logged in. This meant the SOX button would be absent if you were logged out. This new code should fix that. * #310 * #309, #313 * #311, #312 * #256 * #319, #317, #316 * #256 * #318 * #294 deprecate enhanced editor * #308, other small fixes * #320 * minor fixes (#324) change scroll top top feature JSON info * fixes #329 (#330) also reduces jQuery dependency * v2.1.4 DEV before push to master also adds #326 * v2.2.0 * inital DEV push * update readme to state GM not supported; #306 * reduce dependency on `hotkeys`+minor details (#333) * #334 fixed * #334 * #334 * #338 * #335, #338 * Micro optimizations (#336) * update source link * micro optimizations - converted jQuery .not to CSS selector for faster perf (https://stackoverflow.com/questions/8845811/performance-differences-between-using-not-and-not-selectors) - introduced a separate function to eliminate thrice-repeated (!) code, to keep it DRY * fixes some issues (#339) described in #338 (comment) * fixes #338 * fixes #338 (#340) 1. used addEventListener instead of onload 2. descriptive names (`reader`) 3. optimized extraction of the image URL from the `data` 4. made all declarations `var` and moved them into one place for consistency 5. shortened the POST url to simply `'/upload/image?https=true',` ;P * #322 implemented * Sticky property * Update sox.user.js * Updating button colors The main SE buttons use a lighter color than the SOX buttons * Update sox.css * Minor fixes Patched a problem with vote buttons, and fixed the color of the notify on edit button * Update sox.user.js * minor changes/fixes * #341 temporary fix * Updated mod diamond icon Updated to the icon, to match the one used by the new topbar * Updated diamond icon * Updated mod diamond * improvements in colorAnswerer (#344) * improvements in colorAnswerer 1. constant variables+cache answeredID 2. reduce jQuery dependency+shorter a[href] selector via user ID 3. change coloration * optimization: use filters throughout (#345) reduces bandwidth consumption * fixes a few features; adds CSS Fixes moveBounty, dragBounty, copyCommentsLink. Adds class for colorAnswerer. Updates jQuery * fixes quickAuthorInfo fontawesome icon * fix a few of #308 * Major improvements in code extensibility, reduced API usage, eliminate redundancy, etc. (#348) * fixes various bugs mentioned in #348 * fixes standOutDupeCloseMigrated for search pages * remove unwanted console logs * #347, various minor tweaks * fixes small bug in parseCrossSiteLinks e.g. on this comment: https://meta.stackoverflow.com/questions/370902/i-need-a-lot-of-help-to-write-a-query-for-the-stack-exchange-data-explorer-sh?cb=1#comment608548_370902 * Fixed Meta SE's chat link Added a / to the end of Meta SE's if statement to fix it. Also replaced "discuss" with "meta" for Area 51 (to match the new URL for Area 51 Discussions), shortened a bit of code, and added some comments * Fixed Meta SE links * Changed topbar z-index Changed the fixed topbar's z-index to match the one on SO, in order to prevent elements like the usercard (z-index: 1000) from covering it * Made it clearer what the checkbox does * Many fixes to dialog buttons Fixes many of the bugs from #308 * Many fixes to dialog buttons Fixes many of the bugs from #308 * Many fixes to dialog buttons Fixes many of the bugs from #308 * Many fixes to dialog buttons Fixes many of the bugs from #308 * Fixed Area 51 Discussions bug * #348 minor tweak * fix (#350) ...for answerer ID 13 also matching commenter ids beginning with 13 (1345, 13555, etc.) * #352, #353 remove yahoo YQL use * #352 * PR/351 (#355) * update getQuestionTags * provide immediate response to user * minor changes * #325: remove rangyInputs dependency (#354) * bump version number * remove downvotedPostsEditAlert; remove rangyinputs `require`; implement mini changelog in dialog * install stale and no-response bots * #356 added, minor bug fix * start #349, start to move to es6 * onlyShowCommentActionsOnHover bug fix * #357 * deprecate fixedTopbar feature for #349 * add showTagWikiLinkOnTagPopup feature * #359 fixed * #358 fixed * fixes #360 * fixes for #361 * #361 changes * v2.3.0 final * 2.3.0 DEV * fix for #363 * implemented 'feature packs' in settings dialog * debugging for #363, fixes #364 * #363 debugging * fix for #363 * #361 implemented (access token no longer mandatory); minor code cleanup * #365 * fix #368 * Add #315 * fix #366 * start to use linting * fix #372 * add #370 * clean up code * implement #374 * fix #373 * add #370; deprecate pasteImagesDirectly * #374 replace 'help' instead of prepend new link * change indentation to 2 spaces * lint * implement #296 * implements #376 (linkify meta diamond dialog title) * fix #375 (topAnswers post score not being found) * improve customMagicLinks feature -- add button to help menu on all pages * fix sticky vote buttons feature * keep new meta posts under diamond even after clicking (#378) * editComment improve design, add more defaults (#377) * fix better css feature * editComment: make dialog delete button smaller * improve editComment for #377; allow editing; new setting storage format * add delay to comment features for links to deleted comments #379 * bump to v2.4.0 * Remove accidental letter introduced into file * Bump installation link version numbers * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is just a follow-up from Restore previous variant of tag popup so we don't flood the comments there and draw the wrath of the mods on our heads 😉
Installed Version: 2.2.33 DEV Environment: undefined
Current Behaviour
Currently, the script seems to collide with some other SE scripts. The ones I use:
All in all: A great many features SOX offers. I'll have to disable half of them – some for collision reasons, some for "don't need / don't want", and others for "already there" (e.g. the diamond for meta questions – if you're a mod it's already there). If it's not too much trouble, some things I'd wish for:
Other things that don't seem to work (could be collisions again):
SOX Errors logged to the browser console -- F12 (if available)
None.
Steps to reproduce
Features Enabled
Not up-to-date anymore, as I toggled some while writing this post:
The text was updated successfully, but these errors were encountered: