Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments being formatted wrongly #312

Closed
JohnKNess opened this issue Mar 15, 2018 · 8 comments
Closed

Comments being formatted wrongly #312

JohnKNess opened this issue Mar 15, 2018 · 8 comments
Assignees
Labels
Milestone

Comments

@JohnKNess
Copy link

JohnKNess commented Mar 15, 2018

Installed Version: 1.X.X Environment: Chrome/Tampermonkey

SOX: Version 2.1.0
Chrome: Version 64.0.3282.186 (Official Build) (64-bit)
Tapermonkey: v4.5

Current Behaviour

When looking at the comments in the DBA.SE question "How can I improve the performance of a sorted join?" then some of them are elongated.

If I turn off the SOX userscript then comments are back to normal.


SOX Errors logged to the browser console -- F12 (if available)

Errors

userscript.html?id=f50b667d-c5eb-4146-a2e6-5c613ae6bfd2:583 SOX:  There was an error loading the feature "Editing-downvotedPostsEditAlert". Please raise an issue on GitHub, and copy the following error log:
TypeError: Cannot read property 'left' of undefined
sox.error @ userscript.html?id=f50b667d-c5eb-4146-a2e6-5c613ae6bfd2:583
userscript.html?id=f50b667d-c5eb-4146-a2e6-5c613ae6bfd2:583 SOX:  There was an error loading the feature "Voting-stickyVoteButtons". Please raise an issue on GitHub, and copy the following error log:
TypeError: Cannot read property 'top' of undefined
sox.error @ userscript.html?id=f50b667d-c5eb-4146-a2e6-5c613ae6bfd2:583
userscript.html?id=f50b667d-c5eb-4146-a2e6-5c613ae6bfd2:583 SOX:  There was an error loading the feature "Extras-openLinksInNewTab". Please raise an issue on GitHub, and copy the following error log:
TypeError: Cannot read property 'replace' of undefined
sox.error @ userscript.html?id=f50b667d-c5eb-4146-a2e6-5c613ae6bfd2:583
Uncaught TypeError: Cannot read property 'getBoundingClientRect' of undefined
    at Window.eval (userscript.html?id=f50b667d-c5eb-4146-a2e6-5c613ae6bfd2:1420)
    at <anonymous>:2:120
    at T.e.string.f.function.c.(anonymous function) (eval at exec_fn (:1:108), <anonymous>:51:390)

Warnings

userscript.html?id=f50b667d-c5eb-4146-a2e6-5c613ae6bfd2:8 [Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.

Steps to reproduce

Browse to "How can I improve the performance of a sorted join?" with SOX and SOUP userscripts activated.

@JohnKNess
Copy link
Author

This might be because of this:

2018 monthly product team updates

March 2018

Done

Responsive design pt1: Implemented question pages and question list pages. One of the first steps was to remove the tables from the comments on question pages. Comments are now list items. Sorry if the rapid changes break userscripts but it's for the better.

@shu8
Copy link
Member

shu8 commented Mar 17, 2018

@JohnKNess thanks for the bug report! I can't seem to see this -- do you mind posting a screenshot of the comments section so I can see where to look? :)

thanks for the link to the march update too! I'll try updating any features using table specific selectors!

@shu8 shu8 added the bug label Mar 17, 2018
@JohnKNess
Copy link
Author

Ok. Here we go. This is what it looks like when SOX and SOUP are activated and I open a question which contains long comments:

Picture of elongated comments in a DBA.SE question

If I turn off SOX then everything is back to normal. Turning off SOUP has no impact.

@calebkleveter
Copy link

I am also experiencing this issue:

  • SOX 2.1.0
  • Tampermonkey: 4.5
  • Google Chrome: 65.0.3325.162 (Official Build) (64-bit)

@JohnKNess
Copy link
Author

I might have found the culprit.

With certain comments (e.g. one of the comments in the question ORDER BY gives ERROR: function array_position(text[], character varying) does not exist) if I turn on the option Add reply links to comments for quick replying (without having to type someone's username) then the comment will become elongated. If I turn this option off, then the comment behaves normally.

@shu8 shu8 self-assigned this Mar 24, 2018
@shu8 shu8 added this to the 2.2.0 milestone Mar 24, 2018
shu8 added a commit that referenced this issue Mar 24, 2018
@shu8
Copy link
Member

shu8 commented Mar 24, 2018

@JohnKNess @calebkleveter I couldn't reproduce this :( but I've changed the location the reply button is added in v2.1.6 dev which might just fix this -- please could you give it a go and tell me if it works? :)

@calebkleveter
Copy link

calebkleveter commented Mar 24, 2018

Fixed! 👍

@shu8 shu8 closed this as completed Mar 24, 2018
@JohnKNess
Copy link
Author

Seems to work in v2.1.6 dev. Thanks for fixing it.

shu8 added a commit that referenced this issue Sep 2, 2018
* new dev

* #305

* #307

* #310

* #310

* Better fix for #310

The old fix placed the SOX button to the right of the username, but the username only shows up in the top bar if you're logged in. This meant the SOX button would be absent if you were logged out. This new code should fix that.

* #310

* #309, #313

* #311, #312

* #256

* #319, #317, #316

* #256

* #318

* #294 deprecate enhanced editor

* #308, other small fixes

* #320

* minor fixes (#324)

change scroll top top feature JSON info

* fixes #329 (#330)

also reduces jQuery dependency

* v2.1.4 DEV before push to master

also adds #326

* v2.2.0

* inital DEV push

* update readme to state GM not supported; #306

* reduce dependency on `hotkeys`+minor details (#333)

* #334 fixed

* #334

* #334

* #338

* #335, #338

* Micro optimizations (#336)

* update source link

* micro optimizations

- converted jQuery .not to CSS selector for faster perf (https://stackoverflow.com/questions/8845811/performance-differences-between-using-not-and-not-selectors)
- introduced a separate function to eliminate thrice-repeated (!) code, to keep it DRY

* fixes some issues (#339)

described in #338 (comment)

* fixes #338

* fixes #338 (#340)

1. used addEventListener instead of onload
2. descriptive names (`reader`)
3. optimized extraction of the image URL from the `data`
4. made all declarations `var` and moved them into one place for consistency
5. shortened the POST url to simply `'/upload/image?https=true',` ;P

* #322 implemented

* Sticky property

* Update sox.user.js

* Updating button colors

The main SE buttons use a lighter color than the SOX buttons

* Update sox.css

* Minor fixes

Patched a problem with vote buttons, and fixed the color of the notify on edit button

* Update sox.user.js

* minor changes/fixes

* #341 temporary fix

* Updated mod diamond icon

Updated to the icon, to match the one used by the new topbar

* Updated diamond icon

* Updated mod diamond

* improvements in colorAnswerer (#344)

* improvements in colorAnswerer
1. constant variables+cache answeredID
2. reduce jQuery dependency+shorter a[href] selector via user ID
3. change coloration

* optimization: use filters throughout (#345)

reduces bandwidth consumption

* fixes a few features; adds CSS

Fixes moveBounty, dragBounty, copyCommentsLink.
Adds class for colorAnswerer.
Updates jQuery

* fixes quickAuthorInfo fontawesome icon

* fix a few of #308

* Major improvements in code extensibility, reduced API usage, eliminate redundancy, etc. (#348)

* fixes various bugs mentioned in #348

* fixes standOutDupeCloseMigrated for search pages

* remove unwanted console logs

* #347, various minor tweaks

* fixes small bug in parseCrossSiteLinks

e.g. on this comment: https://meta.stackoverflow.com/questions/370902/i-need-a-lot-of-help-to-write-a-query-for-the-stack-exchange-data-explorer-sh?cb=1#comment608548_370902

* Fixed Meta SE's chat link

Added a / to the end of Meta SE's if statement to fix it. Also replaced "discuss" with "meta" for Area 51 (to match the new URL for Area 51 Discussions), shortened a bit of code, and added some comments

* Fixed Meta SE links

* Changed topbar z-index

Changed the fixed topbar's z-index to match the one on SO, in order to prevent elements like the usercard (z-index: 1000) from covering it

* Made it clearer what the checkbox does

* Many fixes to dialog buttons

Fixes many of the bugs from #308

* Many fixes to dialog buttons

Fixes many of the bugs from #308

* Many fixes to dialog buttons

Fixes many of the bugs from #308

* Many fixes to dialog buttons

Fixes many of the bugs from #308

* Fixed Area 51 Discussions bug

* #348 minor tweak

* fix (#350)

...for answerer ID 13 also matching commenter ids beginning with 13 (1345, 13555, etc.)

* #352, #353 remove yahoo YQL use

* #352

* PR/351 (#355)

* update getQuestionTags

* provide immediate response to user

* minor changes

* #325: remove rangyInputs dependency (#354)

* bump version number

* remove downvotedPostsEditAlert; remove rangyinputs `require`; implement mini changelog in dialog

* install stale and no-response bots

* #356 added, minor bug fix

* start #349, start to move to es6

* onlyShowCommentActionsOnHover bug fix

* #357

* deprecate fixedTopbar feature for #349

* add showTagWikiLinkOnTagPopup feature

* #359 fixed

* #358 fixed

* fixes #360

* fixes for #361

* #361 changes

* v2.3.0 final
shu8 added a commit that referenced this issue Feb 3, 2019
* new dev

* #305

* #307

* #310

* #310

* Better fix for #310

The old fix placed the SOX button to the right of the username, but the username only shows up in the top bar if you're logged in. This meant the SOX button would be absent if you were logged out. This new code should fix that.

* #310

* #309, #313

* #311, #312

* #256

* #319, #317, #316

* #256

* #318

* #294 deprecate enhanced editor

* #308, other small fixes

* #320

* minor fixes (#324)

change scroll top top feature JSON info

* fixes #329 (#330)

also reduces jQuery dependency

* v2.1.4 DEV before push to master

also adds #326

* v2.2.0

* inital DEV push

* update readme to state GM not supported; #306

* reduce dependency on `hotkeys`+minor details (#333)

* #334 fixed

* #334

* #334

* #338

* #335, #338

* Micro optimizations (#336)

* update source link

* micro optimizations

- converted jQuery .not to CSS selector for faster perf (https://stackoverflow.com/questions/8845811/performance-differences-between-using-not-and-not-selectors)
- introduced a separate function to eliminate thrice-repeated (!) code, to keep it DRY

* fixes some issues (#339)

described in #338 (comment)

* fixes #338

* fixes #338 (#340)

1. used addEventListener instead of onload
2. descriptive names (`reader`)
3. optimized extraction of the image URL from the `data`
4. made all declarations `var` and moved them into one place for consistency
5. shortened the POST url to simply `'/upload/image?https=true',` ;P

* #322 implemented

* Sticky property

* Update sox.user.js

* Updating button colors

The main SE buttons use a lighter color than the SOX buttons

* Update sox.css

* Minor fixes

Patched a problem with vote buttons, and fixed the color of the notify on edit button

* Update sox.user.js

* minor changes/fixes

* #341 temporary fix

* Updated mod diamond icon

Updated to the icon, to match the one used by the new topbar

* Updated diamond icon

* Updated mod diamond

* improvements in colorAnswerer (#344)

* improvements in colorAnswerer
1. constant variables+cache answeredID
2. reduce jQuery dependency+shorter a[href] selector via user ID
3. change coloration

* optimization: use filters throughout (#345)

reduces bandwidth consumption

* fixes a few features; adds CSS

Fixes moveBounty, dragBounty, copyCommentsLink.
Adds class for colorAnswerer.
Updates jQuery

* fixes quickAuthorInfo fontawesome icon

* fix a few of #308

* Major improvements in code extensibility, reduced API usage, eliminate redundancy, etc. (#348)

* fixes various bugs mentioned in #348

* fixes standOutDupeCloseMigrated for search pages

* remove unwanted console logs

* #347, various minor tweaks

* fixes small bug in parseCrossSiteLinks

e.g. on this comment: https://meta.stackoverflow.com/questions/370902/i-need-a-lot-of-help-to-write-a-query-for-the-stack-exchange-data-explorer-sh?cb=1#comment608548_370902

* Fixed Meta SE's chat link

Added a / to the end of Meta SE's if statement to fix it. Also replaced "discuss" with "meta" for Area 51 (to match the new URL for Area 51 Discussions), shortened a bit of code, and added some comments

* Fixed Meta SE links

* Changed topbar z-index

Changed the fixed topbar's z-index to match the one on SO, in order to prevent elements like the usercard (z-index: 1000) from covering it

* Made it clearer what the checkbox does

* Many fixes to dialog buttons

Fixes many of the bugs from #308

* Many fixes to dialog buttons

Fixes many of the bugs from #308

* Many fixes to dialog buttons

Fixes many of the bugs from #308

* Many fixes to dialog buttons

Fixes many of the bugs from #308

* Fixed Area 51 Discussions bug

* #348 minor tweak

* fix (#350)

...for answerer ID 13 also matching commenter ids beginning with 13 (1345, 13555, etc.)

* #352, #353 remove yahoo YQL use

* #352

* PR/351 (#355)

* update getQuestionTags

* provide immediate response to user

* minor changes

* #325: remove rangyInputs dependency (#354)

* bump version number

* remove downvotedPostsEditAlert; remove rangyinputs `require`; implement mini changelog in dialog

* install stale and no-response bots

* #356 added, minor bug fix

* start #349, start to move to es6

* onlyShowCommentActionsOnHover bug fix

* #357

* deprecate fixedTopbar feature for #349

* add showTagWikiLinkOnTagPopup feature

* #359 fixed

* #358 fixed

* fixes #360

* fixes for #361

* #361 changes

* v2.3.0 final

* 2.3.0 DEV

* fix for #363

* implemented 'feature packs' in settings dialog

* debugging for #363, fixes #364

* #363 debugging

* fix for #363

* #361 implemented (access token no longer mandatory); minor code cleanup

* #365

* fix #368

* Add #315

* fix #366

* start to use linting

* fix #372

* add #370

* clean up code

* implement #374

* fix #373

* add #370; deprecate pasteImagesDirectly

* #374 replace 'help' instead of prepend new link

* change indentation to 2 spaces

* lint

* implement #296

* implements #376 (linkify meta diamond dialog title)

* fix #375 (topAnswers post score not being found)

* improve customMagicLinks feature -- add button to help menu on all pages

* fix sticky vote buttons feature

* keep new meta posts under diamond even after clicking (#378)

* editComment improve design, add more defaults (#377)

* fix better css feature

* editComment: make dialog delete button smaller

* improve editComment for #377; allow editing; new setting storage format

* add delay to comment features for links to deleted comments #379

* bump to v2.4.0

* Remove accidental letter introduced into file

* Bump installation link version numbers

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants