Add reply links to comments is broken

[DavidPostill]

Installed Version: 2.0.45 Environment: Violentmonkey, Windows 7 Home Premium 64 bit, Firefox 58.0.2

When enabled:

Features Enabled

["Appearance-addAuthorNameToInboxNotifications","Appearance-alignBadgesByClass","Appearance-answerTagsSearch","Appearance-colorAnswerer","Appearance-dragBounty","Appearance-fixedTopbar","Appearance-highlightQuestions","Appearance-isQuestionHot","Appearance-markEmployees","Appearance-metaChatBlogStackExchangeButton","Appearance-metaNewQuestionAlert","Appearance-scrollToTop","Appearance-spoilerTip","Appearance-standOutDupeCloseMigrated","Appearance-tabularReviewerStats","Appearance-topAnswers","Appearance-unspoil","Comments-commentReplies","Editing-addSBSBtn","Editing-editComment","Editing-editReasonTooltip","Editing-enhancedEditor","Editing-kbdAndBullets","Editing-titleEditDiff","Editing-inlineEditorEverywhere","Editing-downvotedPostsEditAlert","Flags-flagOutcomeTime","Flags-flagPercentages","Flags-flagPercentageBar","Sidebar-hideHireMe","Sidebar-linkedToFrom","Sidebar-hotNetworkQuestionsFiltering","Chat-chatEasyAccess","Chat-replyToOwnChatMessages","Voting-betterCSS","Voting-grayOutVotes","Voting-stickyVoteButtons","Voting-disableOwnPostVoteButtons","Extras-alwaysShowImageUploadLinkBox","Extras-linkedPostsInline","Extras-parseCrossSiteLinks","Extras-quickAuthorInfo","Extras-shareLinksMarkdown","Extras-sortByBountyAmount","Extras-warnNotLoggedIn"]

[shu8]

@DavidPostill I can't seem to repro this :( it might be a mod thing -- does it happen on other sites where you're not a mod?

[DavidPostill]

Yes. This is on SO where I'm not a mod:

[DavidPostill]

I suppose it could be a clash with some other comment script ...

[shu8]

@DavidPostill if you send me a link to any other comment scripts you have, I could try making it compatible with them too! :)

[DavidPostill]

I've just tried disabling the obvious ones and it's none of those. I did see it some while (months?) ago and it went away. Now it's back.

[DavidPostill]

https://stackapps.com/questions/2050/threaded-comments
https://greasyfork.org/en/scripts/3642-comment-separator-fix
https://meta.stackexchange.com/a/251142/267099

But disabling these doesn't fix the issue :/

[shu8]

That's really weird, I'll try looking into it deeper and get back to you ASAP! On 24 Feb 2018 21:13, "David Postill" <[email protected]> wrote: https://stackapps.com/questions/2050/threaded-comments https://greasyfork.org/en/scripts/3642-comment-separator-fix https://meta.stackexchange.com/a/251142/267099 But disabling these doesn't fix the issue :/ — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#305 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIcNjmPCwYiHXlnOVuZb3NimJRNfi48gks5tYHtngaJpZM4SSCfJ> .

[shu8]

@DavidPostill please could you go to a post where this happens, press F12 to open developer tools, go to the 'Elements' tab, select the html tag and copy the entire page's source code (just hit Ctrl+C after selecting the tag) into a Gist for me to look at?

Hopefully it'll help me find out where this is going wrong

[shu8]

@DavidPostill try DEV v2.1.1 first! I think (hope) I might have found the issue

[DavidPostill]

dev 2.1.1 seems to have fixed it! What was the cause?

[shu8]

Great! It seemed to only be apparent an FF but it was broken in Chrome too! They basically moved one of the html containers in the comments section to a slightly different place so the script was targeting the wrong element when adding the button, and added it *outside* the comment rather than inside it

…

On 25 Feb 2018 21:09, "David Postill" ***@***.***> wrote: dev 2.1.1 seems to have fixed it! What was the cause? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#305 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIcNjgXuGeIUnrwgkDGPKDse0KTN3W8Qks5tYcwZgaJpZM4SSCfJ> .