[platform && device]update centec e582 platform device config files and drivers, update sai to 1.2.4 #1679

yangbashuang · 2018-05-07T08:30:07Z

- What I did

update centec e582 platform device config files and drivers
update sai to 1.2.4
- How I did it
update centec e582 platform device config files and drivers, update sai to 1.2.4
- How to verify it
build success
startup and init success
- Description for the changelog

update centec e582 platform device config files and drivers:

fix e582 driver bugs
support led control
support psuutil
support sfputil
update e582 device config file
update sai:
update sai to 1.2.4

- A picture of a cute animal (not mandatory but encouraged)

update sonic master to centec master

merge sonic master to update

msftclas · 2018-05-07T08:30:18Z

All CLA requirements met.

lguohan · 2018-05-12T08:42:56Z

.gitmodules

@@ -77,3 +77,6 @@
 [submodule "platform/broadcom/sonic-platform-modules-mitac"]
 	path = platform/broadcom/sonic-platform-modules-mitac
 	url = https://github.com/MiTAC-EBU/sonic-platform-modules-mitac.git
+[submodule "platform/centec/sonic-platform-modules-e582"]
+	path = platform/centec/sonic-platform-modules-e582
+	url = https://github.com/CentecNetworks/sonic-platform-modules-e582


hi as we have discussed in community meeting, new platform module should be in tree. can you pull the source code into sonic-buildimage. Thanks.

thanks, i will close this PR and create a new PR after these changes are done.

lguohan · 2018-05-12T08:44:57Z

platform/centec/one-image.mk

+SSHPASS = sshpass
+STRACE = strace
+$(SONIC_ONE_IMAGE)_DBG_PACKAGES += $(GDB) $(VIM) $(OPENSSH) $(SSHPASS) $(STRACE)
+endif


this is not centec platform specific. Can you remove from this PR. You can create a separate PR this DEBUG feature.

thanks, i will close this PR and create a new PR after these changes are done.

lguohan · 2018-05-12T08:45:34Z

platform/centec/rules.mk

 include $(PLATFORM_PATH)/sdk.mk
-include $(PLATFORM_PATH)/sai.mk


if sai.mk file is no longer needed, can you remove that file?

thanks, i will close this PR and create a new PR after these changes are done.

lguohan

as comments

yangbashuang · 2018-05-14T01:50:04Z

thanks, i will close this PR and create a new PR after these changes are done.

yangbashuang · 2018-06-26T05:24:03Z

@lguohan There are two PR opened on 14 May to support centec platform:
#1702
#1703
for a long time not reviewed, wonder to know what i was missing or what should i do next,
Look forward to your reply. thanks

[SFlowMgr] Sflow Crash on 200G ports handled (sonic-net#1683) Remove PGs from an administratively down port. (sonic-net#1677) Stablize the test case (sonic-net#1679) Revert "Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675)" (sonic-net#1682) Signed-off-by: Stephen Sun <[email protected]>

[SFlowMgr] Sflow Crash on 200G ports handled (#1683) Remove PGs from an administratively down port. (#1677) Stablize the test case (#1679) Revert "Revert "[buffermgr] Support maximum port headroom checking (#1607)" (#1675)" (#1682) Signed-off-by: Stephen Sun <[email protected]>

…tilites submodules sonic-swss -[SFlowMgr] Sflow Crash on 200G ports handled (sonic-net#1683) -Stablize the test case (sonic-net#1679) -Remove PGs from an administratively down port. (sonic-net#1677) sonic-swss-common - fix getting hash from redis db (sonic-net#465) - [dbconnector] Initialize redisContext (sonic-net#464) sonic-utilities - route_check: Fix hanging & logging level (sonic-net#1520) - Add self timeout and crash if exceeded. (sonic-net#1502) - [reboot] User-friendly reboot cause message for kernel panic (sonic-net#1486) - [acl-loader]: do not add default deny rule for egress acl (sonic-net#1531) Signed-off-by: Danny Allen <[email protected]>

…tilites submodules (#7209) sonic-swss -[SFlowMgr] Sflow Crash on 200G ports handled (#1683) -Stablize the test case (#1679) -Remove PGs from an administratively down port. (#1677) sonic-swss-common - fix getting hash from redis db (#465) - [dbconnector] Initialize redisContext (#464) sonic-utilities - route_check: Fix hanging & logging level (#1520) - Add self timeout and crash if exceeded. (#1502) - [reboot] User-friendly reboot cause message for kernel panic (#1486) - [acl-loader]: do not add default deny rule for egress acl (#1531) Signed-off-by: Danny Allen <[email protected]>

[SFlowMgr] Sflow Crash on 200G ports handled (sonic-net#1683) Remove PGs from an administratively down port. (sonic-net#1677) Stablize the test case (sonic-net#1679) Revert "Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675)" (sonic-net#1682) Signed-off-by: Stephen Sun <[email protected]>

``` 4818360 [sonic-package-manager] support warm/fast reboot for extension packages (sonic-net#1554) 793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (sonic-net#1679) 24fe1ac [show][config] support for interface alias for muxcable commands (sonic-net#1699) ``` Signed-off-by: Stepan Blyschak <[email protected]>

List of commits (newest first): sonic-net/sonic-utilities@0efd297 (origin/master, origin/HEAD) mclag enhancements as per HLD at sonic-net/SONiC#596 (#1138) sonic-net/sonic-utilities@e98bbb6 Reworked IP validation in "config interface ip add/remove" command (#1709) sonic-net/sonic-utilities@866d1d7 [minigraph][port_config] Consume port_config.json while reloading minigraph (#1705) sonic-net/sonic-utilities@9ae6f6b [debug dump util] Match Infrastructure (#1666) sonic-net/sonic-utilities@8fe7e26 Coverage uses top level directory as source (#1711) sonic-net/sonic-utilities@3f0b690 [MPLS][CLI] added config/show CLI for MPLS interface, MPLS CRM threshold config, updated CLI reference manual sonic-net/sonic-utilities@e8b6c5c [ci] Fix python coverage color bar (#1692) sonic-net/sonic-utilities@888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script (#1706) sonic-net/sonic-utilities@4818360 [sonic-package-manager] support warm/fast reboot for extension packages (#1554) sonic-net/sonic-utilities@793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (#1679) sonic-net/sonic-utilities@24fe1ac [show][config] support for interface alias for muxcable commands (#1699) sonic-net/sonic-utilities@186d851 Pcieutil to load the platform api first instead of using common api (#1672) sonic-net/sonic-utilities@7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (#1640) sonic-net/sonic-utilities@38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (#1658) sonic-net/sonic-utilities@c5d00ae [pfcwd] Fix the return code in invalid case (#1691) sonic-net/sonic-utilities@57dc403 [ci]: Fix config prompt question issue (#1693) sonic-net/sonic-utilities@5708497 [show] fix show version (#1686) sonic-net/sonic-utilities@9041ba0 [config] Adding sanity checks for config reload (#1664) sonic-net/sonic-utilities@2cdadb5 [config]: Create portchannel with LACP key (#1473) sonic-net/sonic-utilities@6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (#1653) sonic-net/sonic-utilities@54fee0f Add range check on portchannel min-links (#1630)

[SFlowMgr] Sflow Crash on 200G ports handled (sonic-net#1683) Remove PGs from an administratively down port. (sonic-net#1677) Stablize the test case (sonic-net#1679) Revert "Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675)" (sonic-net#1682) Signed-off-by: Stephen Sun <[email protected]>

List of commits (newest first): sonic-net/sonic-utilities@0efd297 (origin/master, origin/HEAD) mclag enhancements as per HLD at sonic-net/SONiC#596 (sonic-net#1138) sonic-net/sonic-utilities@e98bbb6 Reworked IP validation in "config interface ip add/remove" command (sonic-net#1709) sonic-net/sonic-utilities@866d1d7 [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1705) sonic-net/sonic-utilities@9ae6f6b [debug dump util] Match Infrastructure (sonic-net#1666) sonic-net/sonic-utilities@8fe7e26 Coverage uses top level directory as source (sonic-net#1711) sonic-net/sonic-utilities@3f0b690 [MPLS][CLI] added config/show CLI for MPLS interface, MPLS CRM threshold config, updated CLI reference manual sonic-net/sonic-utilities@e8b6c5c [ci] Fix python coverage color bar (sonic-net#1692) sonic-net/sonic-utilities@888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script (sonic-net#1706) sonic-net/sonic-utilities@4818360 [sonic-package-manager] support warm/fast reboot for extension packages (sonic-net#1554) sonic-net/sonic-utilities@793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (sonic-net#1679) sonic-net/sonic-utilities@24fe1ac [show][config] support for interface alias for muxcable commands (sonic-net#1699) sonic-net/sonic-utilities@186d851 Pcieutil to load the platform api first instead of using common api (sonic-net#1672) sonic-net/sonic-utilities@7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (sonic-net#1640) sonic-net/sonic-utilities@38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (sonic-net#1658) sonic-net/sonic-utilities@c5d00ae [pfcwd] Fix the return code in invalid case (sonic-net#1691) sonic-net/sonic-utilities@57dc403 [ci]: Fix config prompt question issue (sonic-net#1693) sonic-net/sonic-utilities@5708497 [show] fix show version (sonic-net#1686) sonic-net/sonic-utilities@9041ba0 [config] Adding sanity checks for config reload (sonic-net#1664) sonic-net/sonic-utilities@2cdadb5 [config]: Create portchannel with LACP key (sonic-net#1473) sonic-net/sonic-utilities@6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (sonic-net#1653) sonic-net/sonic-utilities@54fee0f Add range check on portchannel min-links (sonic-net#1630)

- What I did Stabilize the vs test. - Why I did it Stabilize the vs test. - How I verified it Run the vs test. - Details if related One logic in the vs test is to check consistency between APPL_DB and ASIC_DB for buffer profiles. However, the mapping between are stored in the orchagent and can't be accessed from outside. The way we fetch that mapping is: Get the SAI OID of all the buffer profiles in ASIC_DB at the beginning of the test, and store it to set P1 Get the SAI OID of all the buffer profiles in ASIC_DB after a new buffer profile has been created, and stored it to P2 The newly created buffer profile in ASIC_DB should be P2 - P1. However, sometimes there can be more than one OIDs in P2 - P1. This is because the old profile hasn't been removed from the ASIC, which typically caused by timing issues, which fails the test. To make the test case stable, we will retry for 5 seconds to make sure the old profile is removed and the OID of the new profile can be fetched. Signed-off-by: Stephen Sun <[email protected]>

… counters after 'config reload' (sonic-net#1679) - What I did Explanation how show/clear counters works: Suppose we got from SDK some count of dropped packets for priority group (№3) per interface (Ehernet4). (for example Ethernet4 PG-3 123 packets) Stats can be shown via show priority-group drop counters Then we run sonic-clear priority-group drop counters. This command will save data "Ethernet4 PG-3 123 packets" to backup. It saved in /tmp/dropstat-{user_id} folder When we run show priority-group drop counters again, script will take data from SDK and data saved from backup. In backup it will find 123. In SDK it may still be number 123 for Ethernet4 (like in backup) or bigger (for example 126.) Our sonic-clear priority-group drop counters command does not change anything in SDK. It just show difference beetwen SDK data and last saved data. So if in SDK data is 123, show priority-group drop counters will show 0 (123 minus 123) - data is cleared If in SDK data is bigger than saved 124, or higher show priority-group drop counters will show 1 (124 minus 123) FIX After config reload all counters drop counters data retrieved from SDK become cleared. All counters become zeros. In this case show priority-group drop counters will show -123 ( 0 (from SDK) minus 123 (saved backup)) So we don't need backup after config reload - How I did it remove /tmp/dropstat-{user_id} folders with counters backup Signed-off-by: Andriy Yurkiv <[email protected]>

yangbashuang and others added 3 commits April 25, 2018 11:05

Merge pull request #2 from Azure/master

b70dbda

update sonic master to centec master

Merge pull request #4 from Azure/master

143f6dd

merge sonic master to update

update centec platform drivers and sai

9747d80

yangbashuang changed the title ~~[CENTEC]update centec e582 platform device config files and drivers, update sai to 1.2.4~~ [platform && device]update centec e582 platform device config files and drivers, update sai to 1.2.4 May 8, 2018

yangbs added 2 commits May 8, 2018 16:43

update centec platform makefile

d70486a

update centec platform makefile

e7b9088

lguohan reviewed May 12, 2018

View reviewed changes

lguohan requested changes May 12, 2018

View reviewed changes

yangbashuang closed this May 14, 2018

yangbashuang mentioned this pull request May 14, 2018

[platform && device]update centec e582 platform device config files and drivers, update sai to 1.2.4 #1680

Closed

yangbashuang deleted the master branch May 14, 2018 07:15

yangbashuang mentioned this pull request May 14, 2018

[platform && device]update centec e582 platform device config files and drivers, update sai to 1.2.4 #1702

Merged

daall mentioned this pull request Apr 1, 2021

[202012][submodule] Update sonic-swss, sonic-swss-common, and sonic-utilites submodules #7209

Merged

4 tasks

DavidZagury mentioned this pull request Jul 6, 2021

[sonic-utilities] Update submodule #8072

Merged

5 tasks

haslersn mentioned this pull request Jul 17, 2021

updating sonic-utilities submodule #8203

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[platform && device]update centec e582 platform device config files and drivers, update sai to 1.2.4 #1679

[platform && device]update centec e582 platform device config files and drivers, update sai to 1.2.4 #1679

yangbashuang commented May 7, 2018

msftclas commented May 7, 2018 •

edited

Loading

lguohan May 12, 2018

yangbashuang May 14, 2018

lguohan May 12, 2018

yangbashuang May 14, 2018

lguohan May 12, 2018

yangbashuang May 14, 2018

lguohan left a comment

yangbashuang commented May 14, 2018

yangbashuang commented Jun 26, 2018

		include $(PLATFORM_PATH)/sdk.mk
		include $(PLATFORM_PATH)/sai.mk

[platform && device]update centec e582 platform device config files and drivers, update sai to 1.2.4 #1679

[platform && device]update centec e582 platform device config files and drivers, update sai to 1.2.4 #1679

Conversation

yangbashuang commented May 7, 2018

msftclas commented May 7, 2018 • edited Loading

lguohan May 12, 2018

Choose a reason for hiding this comment

yangbashuang May 14, 2018

Choose a reason for hiding this comment

lguohan May 12, 2018

Choose a reason for hiding this comment

yangbashuang May 14, 2018

Choose a reason for hiding this comment

lguohan May 12, 2018

Choose a reason for hiding this comment

yangbashuang May 14, 2018

Choose a reason for hiding this comment

lguohan left a comment

Choose a reason for hiding this comment

yangbashuang commented May 14, 2018

yangbashuang commented Jun 26, 2018

msftclas commented May 7, 2018 •

edited

Loading