Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade configuration restore #1682

Closed
richard28530 opened this issue May 8, 2018 · 1 comment
Closed

upgrade configuration restore #1682

richard28530 opened this issue May 8, 2018 · 1 comment

Comments

@richard28530
Copy link
Contributor

when upgrade all the cofiguration in /etc/sonic will be backup into a folder old_config.
while boot up the minigraph.xml and others(pg_profile_lookup.ini) is not restored from old_config, which will cause some command link 'show interface trans eep' not working.

after each upgrade the directory is deeper.

/host/image-master.0-dirty-20180409.140605/rw/etc/sonic$ tree .
.
|-- config_db.json
|-- minigraph.xml
`-- old_config
    |-- config_db.json
    |-- deployment_id_asn_map.yml
    |-- init_cfg.json
    |-- old_config
    |   |-- buffer.json
    |   |-- buffer1.json
    |   |-- config_db.json
    |   |-- deployment_id_asn_map.yml
    |   |-- minigraph.xml
    |   |-- old_config
    |   |   |-- config_db.json
    |   |   |-- deployment_id_asn_map.yml
    |   |   |-- init_cfg.json
    |   |   |-- minigraph.xml
    |   |   |-- snmp.yml
    |   |   |-- sonic_version.yml
    |   |   `-- updategraph.conf
    |   |-- pg_profile_lookup.ini
    |   |-- snmp.yml
    |   |-- sonic_version.yml
    |   `-- updategraph.conf
    |-- snmp.yml
    |-- sonic_version.yml
    `-- updategraph.conf

3 directories, 24 files
@lguohan
Copy link
Collaborator

lguohan commented Aug 12, 2018

Thanks for reporting, addressed in #1884

@lguohan lguohan closed this as completed Aug 12, 2018
yxieca added a commit to yxieca/sonic-buildimage that referenced this issue Mar 26, 2021
utilities:
* 83f068b 2021-03-22 | Handling error scenario of adding port to Vlan which is part of LAG (sonic-net#1516) (HEAD -> 202012) [Sudharsan Dhamal Gopalarathnam]
* 470e8ce 2021-03-24 | Enable PFCWD only on ports where PFC is enabled (sonic-net#1508) [Andriy Yurkiv]
* 09ef2e0 2021-03-22 | [show][config] add support for setting and displaying switching modes on Y cable (sonic-net#1501) [vdahiya12]
* 0d17d37 2021-03-24 | Warmboot script improvements - timeout exec, disable swss autorestart, remove trap (sonic-net#1495) [Vaibhav Hemant Dixit]
* 2718cd8 2021-03-24 | [show] Fix int status of LAGs, configured as Vlan members (sonic-net#1478) [maksymbelei95]
* cc168fb 2021-03-22 | Fix bug: show vlan config for vlan with no members (sonic-net#1503) [allas-nvidia]

swss:
* 5d8d1fb 2021-03-26 | Revert "Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675)" (sonic-net#1682) (HEAD -> 202012) [Prince Sunny]
* f8df1f8 2021-03-26 | [Dynamic Buffer Calc] Enhance the field checking in table handling (sonic-net#1680) [Stephen Sun]
* 6328c9f 2021-03-22 | [MuxOrch] FDB ageout safety check (sonic-net#1674) [Prince Sunny]
* e1d733e 2021-03-21 | reduce severity of log to info in case of flush on non-existing member (sonic-net#1669) [allas-nvidia]

Signed-off-by: Ying Xie <[email protected]>
lguohan pushed a commit that referenced this issue Mar 27, 2021
utilities:
* 83f068b 2021-03-22 | Handling error scenario of adding port to Vlan which is part of LAG (#1516) (HEAD -> 202012) [Sudharsan Dhamal Gopalarathnam]
* 470e8ce 2021-03-24 | Enable PFCWD only on ports where PFC is enabled (#1508) [Andriy Yurkiv]
* 09ef2e0 2021-03-22 | [show][config] add support for setting and displaying switching modes on Y cable (#1501) [vdahiya12]
* 0d17d37 2021-03-24 | Warmboot script improvements - timeout exec, disable swss autorestart, remove trap (#1495) [Vaibhav Hemant Dixit]
* 2718cd8 2021-03-24 | [show] Fix int status of LAGs, configured as Vlan members (#1478) [maksymbelei95]
* cc168fb 2021-03-22 | Fix bug: show vlan config for vlan with no members (#1503) [allas-nvidia]

swss:
* 5d8d1fb 2021-03-26 | Revert "Revert "[buffermgr] Support maximum port headroom checking (#1607)" (#1675)" (#1682) (HEAD -> 202012) [Prince Sunny]
* f8df1f8 2021-03-26 | [Dynamic Buffer Calc] Enhance the field checking in table handling (#1680) [Stephen Sun]
* 6328c9f 2021-03-22 | [MuxOrch] FDB ageout safety check (#1674) [Prince Sunny]
* e1d733e 2021-03-21 | reduce severity of log to info in case of flush on non-existing member (#1669) [allas-nvidia]

Signed-off-by: Ying Xie <[email protected]>
stephenxs added a commit to stephenxs/sonic-buildimage that referenced this issue Mar 30, 2021
[SFlowMgr] Sflow Crash on 200G ports handled (sonic-net#1683)
Remove PGs from an administratively down port. (sonic-net#1677)
Stablize the test case (sonic-net#1679)
Revert "Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675)" (sonic-net#1682)

Signed-off-by: Stephen Sun <[email protected]>
lguohan pushed a commit that referenced this issue Mar 30, 2021
[SFlowMgr] Sflow Crash on 200G ports handled (#1683)
Remove PGs from an administratively down port. (#1677)
Stablize the test case (#1679)
Revert "Revert "[buffermgr] Support maximum port headroom checking (#1607)" (#1675)" (#1682)

Signed-off-by: Stephen Sun <[email protected]>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this issue May 23, 2021
[SFlowMgr] Sflow Crash on 200G ports handled (sonic-net#1683)
Remove PGs from an administratively down port. (sonic-net#1677)
Stablize the test case (sonic-net#1679)
Revert "Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675)" (sonic-net#1682)

Signed-off-by: Stephen Sun <[email protected]>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this issue Aug 7, 2021
[SFlowMgr] Sflow Crash on 200G ports handled (sonic-net#1683)
Remove PGs from an administratively down port. (sonic-net#1677)
Stablize the test case (sonic-net#1679)
Revert "Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675)" (sonic-net#1682)

Signed-off-by: Stephen Sun <[email protected]>
renukamanavalan added a commit to renukamanavalan/sonic-buildimage that referenced this issue Aug 24, 2021
* e12c1c8 (origin/master, origin/HEAD) disk_check: Script updated (sonic-net#1747)
* 27502f0 [dhcp_relay] Update CLI reference document and add a new API for ip address type (sonic-net#1717)
* cd3ee78 [Config] Update config command of kdump (sonic-net#1700)
* 4cb3b72 [Show] Update the subcommands of Kdump. (sonic-net#1682)
* c03342f [sfputil] Gracefully handle improper 'specification_compliance' field (sonic-net#1741)
* 103de86 [CLI][MPLS][Show] Fixed show and config mpls cli bug where invalid interfaces would pasâsonic-net#1770)
* 04cc047 [route_check] Filter out VNET routes (sonic-net#1612)
* 9395ebd [show][platform] Revise chassis info fallback to only fall back on pmon crash (sonic-net#1751)
lguohan pushed a commit that referenced this issue Aug 25, 2021
* e12c1c8 (origin/master, origin/HEAD) disk_check: Script updated (#1747)
* 27502f0 [dhcp_relay] Update CLI reference document and add a new API for ip address type (#1717)
* cd3ee78 [Config] Update config command of kdump (#1700)
* 4cb3b72 [Show] Update the subcommands of Kdump. (#1682)
* c03342f [sfputil] Gracefully handle improper 'specification_compliance' field (#1741)
* 103de86 [CLI][MPLS][Show] Fixed show and config mpls cli bug where invalid interfaces would pasâ#1770)
* 04cc047 [route_check] Filter out VNET routes (#1612)
* 9395ebd [show][platform] Revise chassis info fallback to only fall back on pmon crash (#1751)
volodymyrsamotiy added a commit to volodymyrsamotiy/sonic-buildimage that referenced this issue Aug 26, 2021
* a72e407 - (HEAD, origin/202012) [202012][fast-reboot] Remove FLEX_COUNTER_TABLE from config_db.json before reboot (sonic-net#1774) (19 hours ago) <Vaibhav Hemant Dixit>
* 205aff8 - (HEAD, origin/202012) [acl_loader]: add iptype match to the rules for dataplane acl (25 hours ago) <Guohan Lu>
* 8aa2226 - Add mock support for swsscommon classes (sonic-net#1780) (26 hours ago) <Qi Luo>
* d939cfb - [Show] Update the subcommands of Kdump. (sonic-net#1682) (3 days ago) <yozhao101>
* 6376b5c - [route_check] Filter out VNET routes (sonic-net#1612) (3 days ago) <Volodymyr Samotiy>
* ba1e457 - [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled (sonic-net#1678) (2 weeks ago) <Andriy Yurkiv>
* 4e7707c - [minigraph] Donot enable PFC watchdog for MgmtTsToR (sonic-net#1734) (2 weeks ago) <Blueve>

Signed-off-by: Volodymyr Samotiy <[email protected]>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this issue Feb 5, 2022
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this issue Apr 28, 2022
Signed-off-by: Yong Zhao [email protected]

What I did
This PR fixed the following issues:

Initially we need add prefix sudo when ran the show command of Kdump. This is unnecessary.

I re-organized the logic of implementing show command and also update the script sonic-kdump-config.

How I did it
Since the script sonic-kdump-config can only be executed by root user, I moved some functions from this file to
the kdump.py such that we do not need run the show command with sudo.

How to verify it
I verified this change on the DuT str-msn2700-03.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants