-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[swss]: update swss submodule #1664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bb85c72 2018-05-01 | Populate existing interface cache, bring down before configDone (sonic-net#491) (HEAD -> master, origin/master, origin/HEAD) [Prince Sunny] * bc97597 2018-04-30 | Add ipv6 ACL support in schema file (sonic-net#490) [zhenggen-xu] * f939b95 2018-04-27 | [qosorch]: Optimizations of qosorch (sonic-net#488) [pavel-shirshov] Signed-off-by: Guohan Lu <[email protected]>
qiluo-msft
added a commit
that referenced
this pull request
May 1, 2018
This reverts commit c74be37.
lguohan
pushed a commit
that referenced
this pull request
May 2, 2018
daall
added a commit
to daall/sonic-buildimage
that referenced
this pull request
Mar 16, 2021
…ux-kernel submodules sonic-swss * Add table descriptions for dynamic buffer calculation to the documents (sonic-net#1664) * Remove vxlanmgrd dependency on orchagent (sonic-net#1647) sonic-utilities * [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (sonic-net#1368) * [warm-reboot]: Check empty key before issuing redis hget (sonic-net#1496) * [generate-dump] Remove Arista specific logic (sonic-net#1482) * [warm-reboot]: added automated recover for ISSU file (sonic-net#1466) * [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (sonic-net#1460) * [show][config] fix for show/config muxcable hwmode model value; fix show/config muxcable return codes; (sonic-net#1494) sonic-linux-kernel * [net] Disable prio and cls cgroups to make working cgroup2 sock matching (sonic-net#198) Signed-off-by: Danny Allen <[email protected]>
Merged
4 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
Mar 18, 2021
…ux-kernel submodules (#7064) sonic-swss * Add table descriptions for dynamic buffer calculation to the documents (#1664) * Remove vxlanmgrd dependency on orchagent (#1647) sonic-utilities * [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (#1368) * [warm-reboot]: Check empty key before issuing redis hget (#1496) * [generate-dump] Remove Arista specific logic (#1482) * [warm-reboot]: added automated recover for ISSU file (#1466) * [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (#1460) * [show][config] fix for show/config muxcable hwmode model value; fix show/config muxcable return codes; (#1494) sonic-linux-kernel * [net] Disable prio and cls cgroups to make working cgroup2 sock matching (#198) Signed-off-by: Danny Allen <[email protected]>
jleveque
added a commit
that referenced
this pull request
Mar 26, 2021
Update sonic-sairedis submodule and also update sonic-swss submodule as there are interdependent changes. * src/sonic-sairedis 13474d1...bc58b0f (12): > Add gbsyncdmgrd; deprecate gbsyncd_startup.py (#809) > Remove gbsyncd_start.sh (#808) > [gbsyncd] Fix shebang in gbsyncd_startup.py; Make script executable (#807) > [saiasiccmp] Add saiasiccmp tool to compare 2 asic views (#791) > [configure] Add -Wno-psabi to remove "passing argument changed in GCC 7.1" (#799) > Update FlexCounter.cpp, use m_pollInterval in MUTEX lock (#797) > [vs] Add special warm boot logic to populate default attributes (#796) > [ci]: add vstest (#795) > [tests] Add macsec unittest (#782) > [debian/control] libsairedis-dev depends on libzmq5-dev (#794) > [ci]: use build template (#793) > Rename duplicate file name (#773) * src/sonic-swss 0b0d24c...5adb73e (47): > Initialize system port type variable (#1681) > [Dynamic Buffer Calc] Enhance the field checking in table handling (#1680) > Handle the clear request for 'Q_SHARED_ALL' (#1653) > [MuxOrch] FDB ageout safety check (#1674) > Deactivate mirror session only when session status is true in updateLagMember (#1666) > Revert "[buffermgr] Support maximum port headroom checking (#1607)" (#1675) > reduce severity of log to info in case of flush on non-existing member (#1669) > Revert "[Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (#1652)" (#1676) > [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (#1652) > [acl] Move ACL table constants to acltable.h (#1671) > [nbrmgrd] added function to parse IP address from APP_DB (#1672) > [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (#1670) > [vog/systemlag] Voq lagid allocator (#1603) > Add table descriptions for dynamic buffer calculation to the documents (#1664) > [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (#1663) > Remove vxlanmgrd dependency on orchagent (#1647) > Keep attribute order in bulk mode (#1659) > [mux] VS test for neigh, route and fdb (#1656) > [linksync] Netdev oper status determination using IFF_RUNNING (#1568) > [portorch] parse on/off value from autoneg (#1658) > [intfsorch] Create subport with the entry contains necessary attributes (#1650) > [ci]: Purge swss before install (#1654) > Update StateDB with error if state change failed, Update APP_DB in all state chg req (#1662) > Added changes to handle dependency check in FdbSyncd and FpmSyncd for warm-boot (#1556) > [synchronous mode] Add failure notification for SAI failures in synchronous mode (#1596) > [acl] Enable VLAN ID qualifier for ACL rules (#1648) > Updated PFCWD to use single ACL table for PFCWD and MUX (#1620) > [orchagent] Increase SAI REDIS response timeout to support FW upgrade during init (Mellanox only). (#1637) > [vstest/nhg]: use dvs_route fixture to make test_nhg more robust > [vstest]: add dvs_route fixture > [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (#1634) > Remove useless header in macsecorch (#1628) > Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group (#1600) > fixed unsupported resource issue (#1641) > [test_virtual_chassis]: use wait_for to make test more robust (#1640) > spell check fixes (#1630) > [bufferorch] Handle NOT IMPLEMENTED status returned during set attr operation (#1639) > [ci]: run vstest > [test_virtual_chassis]: use wait_for function to improve test robustness > [Mux] Neighbor handling based on FDB entry (#1631) > [ci]: use build template (#1633) > Log level change from ERR to INFO for fetch systemports issue (#1632) > Migrate serdes programming to port serdes object (#1611) > [tests] Remove legacy saiattributelist.h dependency (#1608) > [buffermgr] Support maximum port headroom checking (#1607) > Support shared headroom pool on top of dynamic buffer calculation (#1581) > Fix the compiling errors in gcc9 (#1621)
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
Update sonic-sairedis submodule and also update sonic-swss submodule as there are interdependent changes. * src/sonic-sairedis 13474d1...bc58b0f (12): > Add gbsyncdmgrd; deprecate gbsyncd_startup.py (sonic-net#809) > Remove gbsyncd_start.sh (sonic-net#808) > [gbsyncd] Fix shebang in gbsyncd_startup.py; Make script executable (sonic-net#807) > [saiasiccmp] Add saiasiccmp tool to compare 2 asic views (sonic-net#791) > [configure] Add -Wno-psabi to remove "passing argument changed in GCC 7.1" (sonic-net#799) > Update FlexCounter.cpp, use m_pollInterval in MUTEX lock (sonic-net#797) > [vs] Add special warm boot logic to populate default attributes (sonic-net#796) > [ci]: add vstest (sonic-net#795) > [tests] Add macsec unittest (sonic-net#782) > [debian/control] libsairedis-dev depends on libzmq5-dev (sonic-net#794) > [ci]: use build template (sonic-net#793) > Rename duplicate file name (sonic-net#773) * src/sonic-swss 0b0d24c...5adb73e (47): > Initialize system port type variable (sonic-net#1681) > [Dynamic Buffer Calc] Enhance the field checking in table handling (sonic-net#1680) > Handle the clear request for 'Q_SHARED_ALL' (sonic-net#1653) > [MuxOrch] FDB ageout safety check (sonic-net#1674) > Deactivate mirror session only when session status is true in updateLagMember (sonic-net#1666) > Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675) > reduce severity of log to info in case of flush on non-existing member (sonic-net#1669) > Revert "[Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652)" (sonic-net#1676) > [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652) > [acl] Move ACL table constants to acltable.h (sonic-net#1671) > [nbrmgrd] added function to parse IP address from APP_DB (sonic-net#1672) > [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (sonic-net#1670) > [vog/systemlag] Voq lagid allocator (sonic-net#1603) > Add table descriptions for dynamic buffer calculation to the documents (sonic-net#1664) > [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (sonic-net#1663) > Remove vxlanmgrd dependency on orchagent (sonic-net#1647) > Keep attribute order in bulk mode (sonic-net#1659) > [mux] VS test for neigh, route and fdb (sonic-net#1656) > [linksync] Netdev oper status determination using IFF_RUNNING (sonic-net#1568) > [portorch] parse on/off value from autoneg (sonic-net#1658) > [intfsorch] Create subport with the entry contains necessary attributes (sonic-net#1650) > [ci]: Purge swss before install (sonic-net#1654) > Update StateDB with error if state change failed, Update APP_DB in all state chg req (sonic-net#1662) > Added changes to handle dependency check in FdbSyncd and FpmSyncd for warm-boot (sonic-net#1556) > [synchronous mode] Add failure notification for SAI failures in synchronous mode (sonic-net#1596) > [acl] Enable VLAN ID qualifier for ACL rules (sonic-net#1648) > Updated PFCWD to use single ACL table for PFCWD and MUX (sonic-net#1620) > [orchagent] Increase SAI REDIS response timeout to support FW upgrade during init (Mellanox only). (sonic-net#1637) > [vstest/nhg]: use dvs_route fixture to make test_nhg more robust > [vstest]: add dvs_route fixture > [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (sonic-net#1634) > Remove useless header in macsecorch (sonic-net#1628) > Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group (sonic-net#1600) > fixed unsupported resource issue (sonic-net#1641) > [test_virtual_chassis]: use wait_for to make test more robust (sonic-net#1640) > spell check fixes (sonic-net#1630) > [bufferorch] Handle NOT IMPLEMENTED status returned during set attr operation (sonic-net#1639) > [ci]: run vstest > [test_virtual_chassis]: use wait_for function to improve test robustness > [Mux] Neighbor handling based on FDB entry (sonic-net#1631) > [ci]: use build template (sonic-net#1633) > Log level change from ERR to INFO for fetch systemports issue (sonic-net#1632) > Migrate serdes programming to port serdes object (sonic-net#1611) > [tests] Remove legacy saiattributelist.h dependency (sonic-net#1608) > [buffermgr] Support maximum port headroom checking (sonic-net#1607) > Support shared headroom pool on top of dynamic buffer calculation (sonic-net#1581) > Fix the compiling errors in gcc9 (sonic-net#1621)
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jun 22, 2021
5708497 [show] fix show version (sonic-net#1686) 9041ba0 [config] Adding sanity checks for config reload (sonic-net#1664) 2cdadb5 [config]: Create portchannel with LACP key (sonic-net#1473) 6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (sonic-net#1653) 54fee0f Add range check on portchannel min-links (sonic-net#1630)
This was referenced Jun 22, 2021
jleveque
pushed a commit
that referenced
this pull request
Jun 25, 2021
5708497 [show] fix show version (#1686) 9041ba0 [config] Adding sanity checks for config reload (#1664) 2cdadb5 [config]: Create portchannel with LACP key (#1473) 6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (#1653) 54fee0f Add range check on portchannel min-links (#1630)
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 17, 2021
List of commits (newest first): sonic-net/sonic-utilities@0efd297 (origin/master, origin/HEAD) mclag enhancements as per HLD at sonic-net/SONiC#596 (#1138) sonic-net/sonic-utilities@e98bbb6 Reworked IP validation in "config interface ip add/remove" command (#1709) sonic-net/sonic-utilities@866d1d7 [minigraph][port_config] Consume port_config.json while reloading minigraph (#1705) sonic-net/sonic-utilities@9ae6f6b [debug dump util] Match Infrastructure (#1666) sonic-net/sonic-utilities@8fe7e26 Coverage uses top level directory as source (#1711) sonic-net/sonic-utilities@3f0b690 [MPLS][CLI] added config/show CLI for MPLS interface, MPLS CRM threshold config, updated CLI reference manual sonic-net/sonic-utilities@e8b6c5c [ci] Fix python coverage color bar (#1692) sonic-net/sonic-utilities@888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script (#1706) sonic-net/sonic-utilities@4818360 [sonic-package-manager] support warm/fast reboot for extension packages (#1554) sonic-net/sonic-utilities@793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (#1679) sonic-net/sonic-utilities@24fe1ac [show][config] support for interface alias for muxcable commands (#1699) sonic-net/sonic-utilities@186d851 Pcieutil to load the platform api first instead of using common api (#1672) sonic-net/sonic-utilities@7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (#1640) sonic-net/sonic-utilities@38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (#1658) sonic-net/sonic-utilities@c5d00ae [pfcwd] Fix the return code in invalid case (#1691) sonic-net/sonic-utilities@57dc403 [ci]: Fix config prompt question issue (#1693) sonic-net/sonic-utilities@5708497 [show] fix show version (#1686) sonic-net/sonic-utilities@9041ba0 [config] Adding sanity checks for config reload (#1664) sonic-net/sonic-utilities@2cdadb5 [config]: Create portchannel with LACP key (#1473) sonic-net/sonic-utilities@6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (#1653) sonic-net/sonic-utilities@54fee0f Add range check on portchannel min-links (#1630)
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Update sonic-sairedis submodule and also update sonic-swss submodule as there are interdependent changes. * src/sonic-sairedis 13474d1...bc58b0f (12): > Add gbsyncdmgrd; deprecate gbsyncd_startup.py (sonic-net#809) > Remove gbsyncd_start.sh (sonic-net#808) > [gbsyncd] Fix shebang in gbsyncd_startup.py; Make script executable (sonic-net#807) > [saiasiccmp] Add saiasiccmp tool to compare 2 asic views (sonic-net#791) > [configure] Add -Wno-psabi to remove "passing argument changed in GCC 7.1" (sonic-net#799) > Update FlexCounter.cpp, use m_pollInterval in MUTEX lock (sonic-net#797) > [vs] Add special warm boot logic to populate default attributes (sonic-net#796) > [ci]: add vstest (sonic-net#795) > [tests] Add macsec unittest (sonic-net#782) > [debian/control] libsairedis-dev depends on libzmq5-dev (sonic-net#794) > [ci]: use build template (sonic-net#793) > Rename duplicate file name (sonic-net#773) * src/sonic-swss 0b0d24c...5adb73e (47): > Initialize system port type variable (sonic-net#1681) > [Dynamic Buffer Calc] Enhance the field checking in table handling (sonic-net#1680) > Handle the clear request for 'Q_SHARED_ALL' (sonic-net#1653) > [MuxOrch] FDB ageout safety check (sonic-net#1674) > Deactivate mirror session only when session status is true in updateLagMember (sonic-net#1666) > Revert "[buffermgr] Support maximum port headroom checking (sonic-net#1607)" (sonic-net#1675) > reduce severity of log to info in case of flush on non-existing member (sonic-net#1669) > Revert "[Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652)" (sonic-net#1676) > [Dynamic buffer calc] Bug fix: Remove PGs from an administratively down port. (sonic-net#1652) > [acl] Move ACL table constants to acltable.h (sonic-net#1671) > [nbrmgrd] added function to parse IP address from APP_DB (sonic-net#1672) > [MUX/PFCWD] Use in_ports for acls instead of seperate ACL table (sonic-net#1670) > [vog/systemlag] Voq lagid allocator (sonic-net#1603) > Add table descriptions for dynamic buffer calculation to the documents (sonic-net#1664) > [vstest/subintf] Add vs test case to validate processing sequence of APPL DB keys (sonic-net#1663) > Remove vxlanmgrd dependency on orchagent (sonic-net#1647) > Keep attribute order in bulk mode (sonic-net#1659) > [mux] VS test for neigh, route and fdb (sonic-net#1656) > [linksync] Netdev oper status determination using IFF_RUNNING (sonic-net#1568) > [portorch] parse on/off value from autoneg (sonic-net#1658) > [intfsorch] Create subport with the entry contains necessary attributes (sonic-net#1650) > [ci]: Purge swss before install (sonic-net#1654) > Update StateDB with error if state change failed, Update APP_DB in all state chg req (sonic-net#1662) > Added changes to handle dependency check in FdbSyncd and FpmSyncd for warm-boot (sonic-net#1556) > [synchronous mode] Add failure notification for SAI failures in synchronous mode (sonic-net#1596) > [acl] Enable VLAN ID qualifier for ACL rules (sonic-net#1648) > Updated PFCWD to use single ACL table for PFCWD and MUX (sonic-net#1620) > [orchagent] Increase SAI REDIS response timeout to support FW upgrade during init (Mellanox only). (sonic-net#1637) > [vstest/nhg]: use dvs_route fixture to make test_nhg more robust > [vstest]: add dvs_route fixture > [vstest/subintf] Update vs tests to validate physical port host interface vlan tag attribute (sonic-net#1634) > Remove useless header in macsecorch (sonic-net#1628) > Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group (sonic-net#1600) > fixed unsupported resource issue (sonic-net#1641) > [test_virtual_chassis]: use wait_for to make test more robust (sonic-net#1640) > spell check fixes (sonic-net#1630) > [bufferorch] Handle NOT IMPLEMENTED status returned during set attr operation (sonic-net#1639) > [ci]: run vstest > [test_virtual_chassis]: use wait_for function to improve test robustness > [Mux] Neighbor handling based on FDB entry (sonic-net#1631) > [ci]: use build template (sonic-net#1633) > Log level change from ERR to INFO for fetch systemports issue (sonic-net#1632) > Migrate serdes programming to port serdes object (sonic-net#1611) > [tests] Remove legacy saiattributelist.h dependency (sonic-net#1608) > [buffermgr] Support maximum port headroom checking (sonic-net#1607) > Support shared headroom pool on top of dynamic buffer calculation (sonic-net#1581) > Fix the compiling errors in gcc9 (sonic-net#1621)
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
5708497 [show] fix show version (sonic-net#1686) 9041ba0 [config] Adding sanity checks for config reload (sonic-net#1664) 2cdadb5 [config]: Create portchannel with LACP key (sonic-net#1473) 6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (sonic-net#1653) 54fee0f Add range check on portchannel min-links (sonic-net#1630)
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
List of commits (newest first): sonic-net/sonic-utilities@0efd297 (origin/master, origin/HEAD) mclag enhancements as per HLD at sonic-net/SONiC#596 (sonic-net#1138) sonic-net/sonic-utilities@e98bbb6 Reworked IP validation in "config interface ip add/remove" command (sonic-net#1709) sonic-net/sonic-utilities@866d1d7 [minigraph][port_config] Consume port_config.json while reloading minigraph (sonic-net#1705) sonic-net/sonic-utilities@9ae6f6b [debug dump util] Match Infrastructure (sonic-net#1666) sonic-net/sonic-utilities@8fe7e26 Coverage uses top level directory as source (sonic-net#1711) sonic-net/sonic-utilities@3f0b690 [MPLS][CLI] added config/show CLI for MPLS interface, MPLS CRM threshold config, updated CLI reference manual sonic-net/sonic-utilities@e8b6c5c [ci] Fix python coverage color bar (sonic-net#1692) sonic-net/sonic-utilities@888701b [Mellanox] Remove mstdump from Mellanoxs collect dump script (sonic-net#1706) sonic-net/sonic-utilities@4818360 [sonic-package-manager] support warm/fast reboot for extension packages (sonic-net#1554) sonic-net/sonic-utilities@793b847 [show priority-group drop counters] Remove backup with cached PG drop counters after 'config reload' (sonic-net#1679) sonic-net/sonic-utilities@24fe1ac [show][config] support for interface alias for muxcable commands (sonic-net#1699) sonic-net/sonic-utilities@186d851 Pcieutil to load the platform api first instead of using common api (sonic-net#1672) sonic-net/sonic-utilities@7a82c06 [Mellanox] Update mellanox dump generation to include SDK dumps (sonic-net#1640) sonic-net/sonic-utilities@38f8c06 [sfputil] Expose error status fetched from STATE_DB or platform API to CLI (sonic-net#1658) sonic-net/sonic-utilities@c5d00ae [pfcwd] Fix the return code in invalid case (sonic-net#1691) sonic-net/sonic-utilities@57dc403 [ci]: Fix config prompt question issue (sonic-net#1693) sonic-net/sonic-utilities@5708497 [show] fix show version (sonic-net#1686) sonic-net/sonic-utilities@9041ba0 [config] Adding sanity checks for config reload (sonic-net#1664) sonic-net/sonic-utilities@2cdadb5 [config]: Create portchannel with LACP key (sonic-net#1473) sonic-net/sonic-utilities@6f74ba5 [vnet_route_check] Fix logic for getting VNET routes from ASIC DB (sonic-net#1653) sonic-net/sonic-utilities@54fee0f Add range check on portchannel min-links (sonic-net#1630)
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
sonic-net#1664) **What I did** Add table descriptions for dynamic buffer calculation to the documents. **Why I did it** To make the documents aligned with the code.
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
Fixed config reload to add some system sanity checks 1) To check if the system is in running state 2) Check if the services which are grouped under delayed target up 3) Check if swss is running for at least 120 seconds To force config reload and to avoid these checks an extra option -f/--force is added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guohan Lu [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)